CVS edit link for fhelsing

I'm a graphic designer and website developer at the University of California, Berkeley. One of the sites that I designed and currently administer is the Drupal-based "Science Libraries at UC Berkeley" portal
http://www.lib.berkeley.edu/sciences/

During the development process for this site, I created a custom theme. It's a CSS-based design, and the theme package makes use of printer friendly and mobile device friendly style sheets.

Creating mobile friendly websites is one of my special interests, and I've created several such sites for the university library system. Last summer, I taught a class to the library staff on creating mobile friendly websites and posted an online how-to guide (PDF):
http://www.lib.berkeley.edu/digicoll/libraryweb/mobile-websites.pdf

Since I especially enjoy the theming part of creating a Drupal site, I made some modifications to the Science Libraries theme so that it could be used by other Drupal developers. My new theme is called "pinstripes" and a 1000-pixel-wide screenshot is available at:
http://ucblibrary5.berkeley.edu/~fhelsing/drupal/pinstripes/screenshot-l...

If you need any more information, let me know.

Thanks for considering my application!

CommentFileSizeAuthor
#4 pinstripes.zip258.14 KBFleur Helsingor
#1 pinstripes.zip264.31 KBFleur Helsingor

Comments

Fleur Helsingor’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new264.31 KB
avpaderno’s picture

Issue tags: +Theme review
avpaderno’s picture

Status: Needs review » Needs work

The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.
Check the line ending character because in some cases it is not the correct one (it should be the one used by Linux).

Fleur Helsingor’s picture

StatusFileSize
new258.14 KB

OK, I've removed the LICENSE.txt file.

I'm using Mac OS X, and have attempted to save the .php and .css files with Unix line endings. Hopefully, they will work properly now.

Also, let me know if the .info file isn't working properly. I used the Mac OS X plain text editor to create it, but there was no option to set the line breaks. If not, I'll see if I can find something else that will open this file.

avpaderno’s picture

Status: Needs work » Needs review

The default line ending character for Mac OS X is the same as in Linux; the one I found in the previous version of the files was a mix of Windows line ending characters, and Linux line ending characters.

Remember to change the status when you upload new code.

Fleur Helsingor’s picture

Thanks for the reminder. I'm still very new at all things Drupal!

That is odd about the mix of Windows and Linux/Unix line breaks. For some reason, my Mac file editors tend to default to using Windows line breaks, which is something that I'll watch out for as I work on new projects.

avpaderno’s picture

If you don't change the status, probably few people would notice there is new code to review (not that there are so much people to review code here, but I am not supposed to be the only one who do that :-)). That is the reason for the reminder, which is not absolutely a way to remark you did something wrong (which is not true at all).

avpaderno’s picture

Status: Needs review » Fixed
Fleur Helsingor’s picture

Status: Fixed » Closed (fixed)

My new theme went live just a few minutes ago, so I'll close out this task.

Thanks for all of your help with this, kiamlaluno!

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.