Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Arianek and I decided to split up [#632716]into smaller issues/patches. Please review the relevant section of the last patch for this that can be found at http://drupal.org/node/632716#comment-2285200
Post review / screenshots and rerolled patches here -- thanks!
Comment | File | Size | Author |
---|---|---|---|
#13 | 645796.patch | 7.57 KB | jhodgdon |
#10 | triggerhelp.png | 21.89 KB | jhodgdon |
#10 | triggerspage.png | 14.09 KB | jhodgdon |
#10 | actionsscreen.png | 28.83 KB | jhodgdon |
#10 | 645796.patch | 7.56 KB | jhodgdon |
Comments
Comment #1
arianek CreditAttribution: arianek commentedmanually cut this from the mondo patch
Comment #2
tobiasbComment #3
lisarex CreditAttribution: lisarex commentedThis patch hasn't been reviewed properly yet.
- put caps on modules
- moved link to handbooks as per other help patches
- put caps on linked pages
I'm sure there's more to say about this module, but I don't know it well enough :)
Also, the text is word-for-word what's in the handbook page. Should we try to get more inventive (if there's time?)
Comment #5
lisarex CreditAttribution: lisarex commentedPlease review the patch that passed and ignore the failed patch. It was actually a png with a bad file extension :D
Comment #6
arianek CreditAttribution: arianek commentedassuming the functionality of this module hasn't changed massively, this looks good to me - made one small grammar tweak, but otherwise thumbs up.
Comment #7
webchickCool, committed to HEAD.
This help file probably needs a good revamp with some more step-by-step instructions, but I'm not sure who other than jhodgdon, cwgordon7, or jvandyk would be able to write it. If such a thing were to materialize in the next week or so, though, I'd happily commit it.
Comment #8
jhodgdonI'll take a stab at it, as soon as I wake up. :)
Comment #9
jhodgdonComment #10
jhodgdonOK. Here's an update. I changed the help for the Trigger module and on the Trigger and Actions admin pages. Also changed some header text on the Actions page. See screenshots.
As a note, I think that one of the most confusing things people might not realize is that they have to make an advanced action when it might seem like they need an advanced trigger. For instance, you want a certain action to take place only if certain words are in the content. But you can't trigger on "content is created with certain words" (triggers are not configurable). You instead trigger on 'content is created' and the action is "unpublish content with certain words'. I tried to make this clear in the help text, without calling attention to the weirdness of it all. Hopefully. Other than that, I think the steps are pretty clear (verify/configure the action and then assign it to a trigger), so I didn't think too much needed to be said.
Comment #11
arianek CreditAttribution: arianek commented- on the Triggers page i think it should be "...such as new content being added OR a user logging in"
- on the Actions page, i think it should be "Create AN advanced action" for the title
(didn't roll a patch as the second is debatable)
Comment #12
jhodgdonAgree with your first suggestion (typo). Second is OK too.
Comment #13
jhodgdonHere's a patch incorporating both of the suggestions from #11. No other changes, and I didn't make new screen shots.
Comment #14
arianek CreditAttribution: arianek commentedgetting
Hunk #1 succeeded at 2789 (offset 9 lines).
Hunk #2 succeeded at 2816 (offset 9 lines).
but it seems to apply regardless - RTBC
Comment #15
Dries CreditAttribution: Dries commentedGreat. Thanks. Committed to CVS HEAD.