Passing dynamic arguments to access plugins [#644008]

I am trying to accomplish the following:

I have made a view with a "page" display, that uses one argument to filter by taxonomy term ID. By using the taxonomy_menu module I create a menu of the taxonomy terms of which each menu item points to the view. Now I would like to hide (deny access) all menu items that point to a term to which there are no nodes associated.

I've tried writing a Views access plugin to accomplish this. However, I'm getting into trouble when trying to get grip on dynamic access arguments. It seems not to be possible to pass them to my views access plugin.

function get_access_callback() {
    return array('option_views_check_terms_having_nodes', array(1));
  }

menu_unserialize() does dynamic argument replacements in the array inside access_arguments, but in the case of views the actual access arguments for the access plugin are located in a nested array inside the main array.

example access_arguments:

array(1) {
  [0]=>
  array(2) {
    [0]=>
    string(46) "option_views_check_terms_having_nodes"
    [1]=>
    array(1) {
      [0]=>
      int(1)
    }
  }
}

What I suggest to fix this is that any integer access arguments returned by get_access_callback() of a views access plugin are added to the main access_arguments() array, so they get replaced there dynamically with the path argument by menu_unserialize():
array(1) { [0]=> array(2) { [0]=> string(46) "option_views_check_terms_having_nodes" [1]=> array(1) { [0]=> int(1) // 1 refers now to the key in the main array } }, [1]=> }

Then, views_access() needs to replace the key pointers inside the nested arrays with the values from the main array.

I'm sorry if my explanation is not very clear :) I will try to write a patch.

Comment	File	Size	Author
#16	644008-views-dynamic_acesss_arguments.patch	12 KB	dawehner
#16
#15	644008-views-dynamic_acesss_arguments.patch	2.51 KB	dawehner
#15
#8	644008-views-dynamic_acesss_arguments.patch	2.47 KB	dawehner
#8
#7	views-644008.patch	2.22 KB	dawehner
#7
#3	views-644008.patch	2.54 KB	Cyberwolf
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

merlinofchaos CreditAttribution: merlinofchaos commented 26 November 2009 at 17:33

This functionality is part of the 3.x roadmap (see http://www.angrydonuts.com/views-3-x-roadmap) so patches will be very appreciated here!

Comment #2

dagmar

Spanish

Argentina

CreditAttribution: dagmar commented 28 November 2009 at 20:28

Issue tags:

+views 3.x roadmap

Tagging.

Comment #3

Cyberwolf CreditAttribution: Cyberwolf commented 1 December 2009 at 14:42

File	Size
views-644008.patch	2.54 KB

Attaching a patch against HEAD. Let me know what you think about it.

Comment #4

dagmar

Spanish

Argentina

CreditAttribution: dagmar commented 1 December 2009 at 16:08

I didn't test it but, the syntax of $variables in views is $variable_one and not $variableOne

Comment #5

Cyberwolf CreditAttribution: Cyberwolf commented 2 December 2009 at 11:11

Sorry, I'm used to camel case coding style :) Will fix it when I have some more time.

Comment #6

dawehner

German

CreditAttribution: dawehner commented 13 February 2010 at 15:35

Status:

Active

» Needs work

Comment #7

dawehner

German

CreditAttribution: dawehner commented 13 February 2010 at 15:42

File	Size
views-644008.patch	2.22 KB

Update codestyle, merge with current version, but

I would like to see a explanation whats going on in ivews_plugin_display_page, some inline comments would be important.
I don't really know whats happens here ;)

"Optional": A simpletest to test this would be cool.

Comment #8

dawehner

German

CreditAttribution: dawehner commented 1 May 2010 at 15:11

Status:

Needs work

» Needs review

File	Size
644008-views-dynamic_acesss_arguments.patch	2.47 KB

This is the same patch which some comment inline. I would suggest to review this part, i don't know whether i understood it right.

Comment #9

dawehner

German

CreditAttribution: dawehner commented 9 June 2010 at 22:12

Status:

Needs review

» Needs work

+++ plugins/views_plugin_display_page.inc
@@ -71,6 +71,36 @@ class views_plugin_display_page extends views_plugin_display {
+        if (is_int($value)) {
+          $access_arguments[$i] = $value;
+          $access_plugin_arguments[$key] = $i;
+          $i++;
+        }

We should allow to use strings too. Perhaps there is something which can be defined in the access plugin formular which whould be able for the access callback.

+++ views.module
@@ -453,6 +453,12 @@ function views_access() {
+      if (is_int($value) && isset($args[$value])) {
+        $arguments[$key] = $args[$value];
+      }

The same case here.

Powered by Dreditor.

Comment #10

dawehner

German

CreditAttribution: dawehner commented 19 June 2010 at 19:17

Status:

Needs work

» Needs review

The access plugin can do this already.

Comment #11

dawehner

German

CreditAttribution: dawehner commented 13 August 2010 at 20:42

Issue tags:

+alpha-4 blocker

add tag

Comment #12

Remon CreditAttribution: Remon commented 3 December 2010 at 14:24

Bumping last alpha-4 blocker.

Comment #13

merlinofchaos CreditAttribution: merlinofchaos commented 10 December 2010 at 00:32

Priority:	Normal	» Critical
Status:	Needs review	» Needs work

Okay. Patch doesn't apply, though hopefully it should be an easy reroll.

This also needs some documentation. I guess access plugins aren't really documented...at all, so maybe we should put in some stub documentation for access plugins somewhere to make it a little easier to understand how to do these.

Sadly, our access plugins are not nearly as interesting as CTools' access plugins, but maybe we can do some kind of transfer thing somewhere. That'd be pretty rad, though I don't have any idea how to actually get the complicated UI to fit inside the Views UI. Still, if we could do that, the amount of power we could gain would be extensive.