Found while debugging #553306-76: Make nodes have no body field by default. Remove deprecated APIs for body field:

'Translatable fields' and entity_info have a dependency on the number of languages enabled on a site, through locale_entity_info_alter()

Yet a call to locale_add_language() ("API function to add a language") doesn't refresh the cached entity_info.

Related: #642612: No clean way to reset entity_info cache.

CommentFileSizeAuthor
#5 language_add-642614-2.patch1.19 KBplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Component: locale.module » language system
Issue tags: +translatable fields

Cleaning-up the "locale module" issue queue as per http://cyrve.com/criticals.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

This moves the hook_multilingual_settings_changed() invocation from the submit handler to locale_add_language().

Related to #632172: Node language and field languages may differ.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Active » Needs review
yched’s picture

yched CreditAttribution: yched commented

no patch ? :-)

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
FileSize
language_add-642614-2.patch1.19 KB

lol :)

yched’s picture

yched CreditAttribution: yched commented

Looks good. Should a similar change (move notification from form submit to API func) be done when a language is disabled / removed ?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Obviously the answer should be "of course", unfortunately we have no API function to disable/remove languages.

yched’s picture

yched CreditAttribution: yched commented

OK. Looks RTBC, then, but I guess sun should review ?

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community

aight - plach just clarified that there are no API functions for changing/removing languages.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -translatable fields

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +translatable fields

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.