More granular argument validation for OG Group Nodes

This is working well for us in our dev environment.

subscribing, I have been trying to configure an argument to do exactly this, apply to specific group type, http://drupal.org/node/638058

I will give this patch a try.

sorry, my dev environment isn't to the point of running patches and I was hoping to be able to do this fast manually.

I am trying to apply to og 6.x-2.0 and can't seem to get my bearings with the patch. I had a quick look at the files in og 6.x-2.x-dev but still having problems. I must be missing something simple. Any help would be appreciated. Thanks.

Sorry to be a pest. I am very new to applying patches in Drupal and would appreciate any help.

I used a patch utility in WinOS to apply the patch to og 6.x-2.0 and it is not working. I am getting a .rej file. I do not know what I am supposed to make of this file. I am attaching it in case someone can suggest to me what I should try next. I would really like to use this patch.

Thanks,

Izzy

Thanks for the quick response.

No, I was not applying it to the dev version. I looked at the og_views_plugin_argument_validate_og_group_types.inc file in both og 6.x-2.0 and og 6.x-2.x and they looked identical.

Thanks for the file attachment. Do I need to apply the patch to this file?

Izzy

Thanks, I thought so and have run tests and it works great. I also like the additions in the validator to choose if the user is a member of the group or an admin or neither. This patch is very useful.

Izzy

I have tested the patch with og 6.x-2.0 and it seems to work great.

I will go ahead and change the status of the issue to reviewed by community but had previously held off because I thought it needed to reach a certain threshold to qualify for that status.

Thanks again for this very useful patch. I would suggest this should be committed to og as soon as possible as it is a feature that is fundamental to configuring the module.

Izzy

OT: Sorry to use so much bandwidth, but I wondered about changing the title of the issue to "Group type validation for Group nodes validator" ?

I didn't change it because I find it can be confusing when others change titles of posts, so I would rather leave that to whoever started the thread or someone with a fully understanding if they think it's even worthwhile.

Changing title --

Also, to reiterate from above: this has been working flawlessly for us.

Hello!

Any feedback on this?

This is in place, working well, and has been perfectly stable.

It allows you to be much more flexible in creating different options for group types.

Not sure what feedback you are looking for.

I agree this is a VERY useful addition to og_views and seems to be totally stable on OG 2.0

As a novice Drupal user I'm not really clear on the next steps.

Does this patch need to be committed to the dev release so it can become part of the next release?

My quick encounter with the dev release a couple of weeks ago seemed to cause some hiccups. Unfortunately, I was too pressed for time to explore why and reverted to og 6.x-2.0

I appreciate there are efforts to address a number of the issues in the og queue for the next release and issues with views.

It would be great to see this patch in og. Meanwhile, others can apply it or use the zip file.

I'll have to find some time to test out the current og dev again soon.

Izzy

Did somebody ask for pretty pictures? Sweet! I'd love to!

The screenshot below shows what is added by this patch:

So, using the options shown with this patch, and the options shown in the screenshot below--

-- it is possible to show different views, for different group types, to different users based on their group membership.

To break this down into a practical use case:

Let's say a school has classes and clubs set up as group types. The person running the site wants people who manage classes to be able to email users and reset their passwords; however, all people in clubs should only be able to email members from that club.

Using this patch (in conjunction with Views Bulk Operations), this type of functionality becomes possible, and group admins/members can be given very targeted rights based on membership in a group.

Committed. Thanks for your patience and persistence and pictures.

It's almost there - marcp can you please add some PHPdocs to validate_group_node_type()

[edit: seems to cross post with Moshe. A follow up patch on the docs with be still nice :) ]

Is this committed?

If not, what additional feedback/review is needed?

And btw, I was referring to the PHPdocs in #22 --

I was doing some house cleaning and noticed that the status of this ticket has not changed but the feature was committed on December 15, 2009 and is in OG 2.1

Should this issue status be changed to "fixed" or "closed" ?

Thanks.

Committed docs, thanks.