agill [agill]

  $bookedunits = db_query("SELECT  tn.nid AS tnid, tn.title AS title, nt.type, nt.name FROM {merci_reservation_detail} m INNER JOIN {node} pn ON m.placeholder_nid = pn.nid INNER JOIN {node_type} nt ON pn.type = nt.type LEFT JOIN {node} tn ON m.item_nid = tn.nid WHERE m.vid = %d", $paramnid);

1. The query is not wrapped by db_rewrite_sql()
2. The query doesn't include WHERE node.status = 1
3. {node} tn should be {node} n
4. Not sure but I think you should SELECT from the {node} n table and INNER JOIN the other tables.

Didn't get any further as that jumped out at me on page 1.

1.     $sql = db_rewrite_sql("SELECT n.nid, n.title AS title,ctar.nid ,ctar.field_agreservations_unitnumber_value  FROM {node} n INNER JOIN {content_type_agreservations_unit} ctar ON n.nid = ctar.nid WHERE (status=1 and type='agreservations_unit') order by ctar.field_agreservations_unitnumber_value");
       $res = db_query(db_rewrite_sql($sql));
   

   What is wrong in that code?

2. Why is the module overwriting the theme functions it defines? Why isn't giving the correct definition in hook_theme()?

3.     $units = _agreservations_get_unitnodes();//A.Gill Alle Räume aus der Datenbank holen
   

   Comments should be in English.

4. Check the character used to indent the code, which should be 2 spaces.

5.                     $tmpdefaultdate1 = new DateTime($_REQUEST['default_merci_date']);
   

   Drupal 6 is still compatible with PHP 4; is the class DateTime available for PHP 4?

6.     if (isset($form['type'])) {
           if (isset($form['type']['#value'])) {
               if ($form['type']['#value'] == 'merci_reservation') {
   

   The code can be simplified.

7.     $node->field_agres_userref[0]['uid']   = $userid;
       node_save($node);
   

   That is not the correct way to save a node object.

8.   require_once './' . drupal_get_path('module', 'content')
         . '/modules/content_copy/content_copy.module';
   

   There is a Drupal function that should be called instead of executing that code.

9. _agreservations_install_cck_unit(), and _agreservations_install_cck_mercireservation() could be replaced by a single function that accepts parameters.
10. Verify the code is respecting the module namespace.

The only thing I see that's not properly namespaced under the module name is the _remove_cck_fields function in agreservations.install.

I confirm what reported by sreynen. Functions defined by the module needs to respect the namespace, which means the function names must follow a defined schema.