Removed $ by mistake in boosted1/2.txt & boost-rules page [#636704]

Hi guys,

As I was reviewing the changes real quick, I noticed a discrepancy which I thought may be a mistake.

The HTML and CSS both do not have the $ at the end whereas they had it before and the other entries have it...

-  <FilesMatch "\.html\.gz$">
+  <FilesMatch "(\.html|\.html\.gz)">
     ForceType text/html
   </FilesMatch>
-  <FilesMatch "\.xml\.gz$">
+  <FilesMatch "(\.xml|\.xml\.gz)$">
     ForceType text/xml
   </FilesMatch>
-  <FilesMatch "\.json\.gz$">
+  <FilesMatch "(\.json|\.json\.gz|\.js|\.js\.gz)$">
     ForceType text/javascript
   </FilesMatch>
-  <FilesMatch "\.css\.gz$">
+  <FilesMatch "(\.css|\.css\.gz)">
     ForceType text/css
   </FilesMatch>
-  <FilesMatch "\.js\.gz$">
-    ForceType text/javascript
-  </FilesMatch>

Thank you.
Alexis Wilke

Comment	File	Size	Author
#2	boost-636704.patch	2.64 KB	mikeytown2
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

AlexisWilke CreditAttribution: AlexisWilke commented 18 November 2009 at 22:42

It is in boosted1.txt too, btw.

Comment #2

mikeytown2 CreditAttribution: mikeytown2 commented 18 November 2009 at 22:52

Title:

Removed $ by mistake in boosted1/2.txt & boost-rules page

» Removed $ by mistake in boosted2.txt?

File	Size
boost-636704.patch	2.64 KB

yep this is an opps... root of this has to do with the function I use to generate the rules inside the boost.admin file. attached is a patch that fixes the issue in all 3 files.

It's the HTML and CSS that are effected correct? This is a minor bug, it only effects you if your running a very recent version of apache that doesn't implement T= correctly in the rewrite rules.

Comment #3

mikeytown2 CreditAttribution: mikeytown2 commented 18 November 2009 at 22:51

Title:	Removed $ by mistake in boosted2.txt?	» Removed $ by mistake in boosted1/2.txt & boost-rules page
Status:	Active	» Needs review

Comment #4

mikeytown2 CreditAttribution: mikeytown2 commented 18 November 2009 at 23:38

Title:	Removed $ by mistake in boosted2.txt?	» Removed $ by mistake in boosted1/2.txt & boost-rules page
Status:	Needs review	» Reviewed & tested by the community

committed; leaving as RTBC since 1.16 links to this issue now as a know issue.