In taxonomy_link if taxonomy_term_path returns a path that includes a query or fragment, the links that get created are messed up.

This can be fixed by splitting the url from taxonomy_term_path before using it to create the link.

The attached patch fixes this problem.

Thanks to dman for the fix, posted at http://drupal.org/node/325132#comment-1528052

CommentFileSizeAuthor
#8 taxonomy-link_query_fragment-632646-8.patch1 KBAgileware
#6 taxonomy_link_query_fragment-632646-6.patch1.18 KBAgileware
taxonomy_link_query_fragment.patch1.08 KBAgileware
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Agileware’s picture

Agileware CreditAttribution: Agileware commented

taxonomy_link is no longer in drupal 7 so this doesn't need porting to 7

dman’s picture

dman CreditAttribution: dman commented

+1 on this. Fixes a problem.
Although it's so late now (though the issue was a year and a half old) I don't hold high hopes for anyone bothering to fix it in core D6. :-(
Would need a test and stuff.

Status: Needs review » Needs work

The last submitted patch, taxonomy_link_query_fragment.patch, failed testing.

Agileware’s picture

Agileware CreditAttribution: Agileware commented

I have checked the patch and it still applies cleanly to the current cvs version.

When I get some time over the next couple of weeks I will learn how to write tests and give that a go.

dman’s picture

dman CreditAttribution: dman commented

testbot failed because the patch included your path 'drupal-6.x-dev'.
Need to build it from inside drupalroot IIRC

Agileware’s picture

Agileware CreditAttribution: Agileware commented
Status: Needs work » Needs review
FileSize
taxonomy_link_query_fragment-632646-6.patch1.18 KB

Here is the same patch created against cvs from inside the drupal root.

Weird though, I though as long as it applied with patch -p0 it would be ok.

Status: Needs review » Needs work

The last submitted patch, taxonomy_link_query_fragment-632646-6.patch, failed testing.

Agileware’s picture

Agileware CreditAttribution: Agileware commented
Status: Needs work » Needs review
FileSize
taxonomy-link_query_fragment-632646-8.patch1 KB

OK, since we have moved to git I'll have one more try to get this to work.
This one is the same patch made with git.

dman’s picture

dman CreditAttribution: dman commented

Hell yeah, let me unpatch core.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.