Add devel timing for page views and embedded views [#631522]

Views provide integration with Devel to display the time taken to create a view.

But, the current version of views only displays the timing info when the view is in a block only. If the view is a page, or is embedded, no timing information is displayed.

The attached patch fixes this, and displays timing information for page views and embedded views.

This is against 6.x-2.x-dev, but applies with offset to 6.x-3.x-dev as well. I tested it on a couple of sites and it works well.

Comment	File	Size	Author
#10	views-7.x-timing_1_0_0.patch	1.9 KB	dawehner
#8	views-6.x-timing_1_0.patch	2.4 KB	dawehner
#7	views-6.x-timing_1.patch	2.61 KB	dawehner
#5	views-6.x-timing_1.patch	2.51 KB	kbahey
#3	views-6.x-timing.patch	2.5 KB	kbahey
#1	views-6.x-timing.patch	1.24 KB	kbahey

Comments

Comment #1

kbahey commented 13 November 2009 at 01:52

Status	File	Size
new	views-6.x-timing.patch	1.24 KB

And the patch itself is now attached.

Comment #2

merlinofchaos commented 13 November 2009 at 18:28

Instead of duplicating the code, can we move the code so that all views -- page, block, embedded, calendar, feeds, etc, can benefit from this?

Comment #3

kbahey commented 13 November 2009 at 20:01

Status	File	Size
new	views-6.x-timing.patch	2.5 KB

The page and block ones use the $view->execute_display(), the embed one uses $view->preview().

Is it enough to change the execute_display() and the preview() functions in the views.inc file, or is there other stuff I am missing?

I attached a patch that puts the display in the preview and in the execute_display. See if that is enough. If it is not, then point me in the right direction ...