While bbcode-filter.inc has table support the bbcode-help.inc file does not mention it.
bbcode-help.inc should be expanded to mention this support.

Comments

naudefj’s picture

Status: Active » Needs work

Can you please prepare a patch?

nileshgr’s picture

Title: bbcode suuports table but does not mention it in the help » bbcode supports tables, and some others but does not mention it in the help
Version: master » 6.x-1.2

Its not only table, but there are couple of others too.

I'll be submitting a patch in a day or two.

nileshgr’s picture

Damn me. I wasn't able to spare even five minutes to this job !! :! :!
I will do this asap

TapSkill’s picture

Help page also needs to mention quotes and how they work.

It would be nice if someone came up with a forum-oriented module to include a "reply with quote" or "reply directly to this user" icon/link, and then, the quote is automatically added in the comment field. It's not necessary, but it would be an awesome module.

nileshgr’s picture

I think you need to check out the quote module here. http://drupal.org/project/quote

nileshgr’s picture

Status: Needs work » Needs review
StatusFileSize
new3.45 KB

I have prepared the patch. Review & commit it.

PS: You will have to specify -R during patching. I think the arguments were misplaced :( and I deleted the modified file :(

naudefj’s picture

Status: Needs review » Needs work

Patch is invalid. It deletes a bunch of lines that isn't in the file (wrong way diff maybe?)

nileshgr’s picture

StatusFileSize
new37.01 KB

It is valid, see the attached image -

Ignore that Ctrl-C, it was a typo.

naudefj’s picture

$ patch -p0 -li bbcode-help.patch           
patching file bbcode-help.inc                                         
Reversed (or previously applied) patch detected!  Assume -R? [n] y    
Hunk #3 FAILED at 238.                                                
1 out of 3 hunks FAILED -- saving rejects to file bbcode-help.inc.rej

If you cannot do another diff, please upload the entire updated file.

nileshgr’s picture

StatusFileSize
new14.63 KB

Its very funny though. I think you're using the CVS version. With 6.x-1.2, the patch works as I showed it in the screenshot.
Here's the complete file :)

nileshgr’s picture

StatusFileSize
new3.16 KB
new14.34 KB

Hi, it seems the Abbreviations and Acronyms part got repeated, as the help file already had them.

Here's the patch and the new file :)

nileshgr’s picture

StatusFileSize
new14.34 KB
new3.15 KB

Sheesh. Bugs bugs bugs. I *hope* this is the final.

naudefj’s picture

Status: Needs work » Patch (to be ported)