Increase maximum length of the free-tagging textbox to 255 characters

Committed to HEAD.

The field itself does not appear to be saved directly to the database (only split and saved), so reopen if you confirm and want more than 255 characters.

I'm running into the 255 character limit...

This is the same 255 in HEAD. It should be patched there and then backported.

It's at 255 now. What should the max length be? 512?

Patch is attached. The max length is now 512.

The DB's maximum is per-tag, so the field maximum can effectively be unlimited for tags.

Hmmm...If I remove the '#maxlength' altogether, the field defaults to a maxlength of 128. I'm not sure where this is being set though. It looks like it's in system_elements() in system.module. I can certainly re-roll a patch that sets the maxlength of the tags field to some arbitrary length like 10,000 or something!

@karschp: Hmmm. Could you try unset($form['...']['#maxlength']) maybe, after the definition?

Also, make sure that you're rolling patches with cvs diff -up because that gives a bit of context and makes them easier to read.

OK, I'm sure I implemented this incorrectly, but here's a patch that adds a function _taxonomy_set_maxlength that basically takes the "tags" element on #after_build and unsets the #maxlength attribute. We're nearing the limits of my drupal knowledge...I'm trying not to screw things up too much.

Ah, no, I'm sorry. That was my fault for giving a crappy explanation because I was rushed. But um. Neat! I had no idea you could do that. :D

What I meant was:

        $form['taxonomy']['tags'][$vocabulary->vid] = array(
          '#type' => 'textfield',
          '#title' => $vocabulary->name,
          '#description' => $help,
          '#required' => $vocabulary->required,
          '#default_value' => $typed_string,
          '#autocomplete_path' => 'taxonomy/autocomplete/' . $vocabulary->vid,
          '#weight' => $vocabulary->weight,
          # Note: I removed #maxlength because we don't need it.
        );
        // Unset the #maxlength attribute on the text field, since the database maximum is per-tag.
        unset($form['taxonomy']['tags'][$vocabulary->vid]['#maxlength']);
      }
      else {

Mind you, I don't know if this will actually work, because I haven't tested it. If it doesn't, then we should probably go back to setting maxlength to something like 512 or 1024, because that's a bit more straight-forward use of the property than the solution in #12.

Yeah, I tried it that way first and it wasn't working so I did the #after_build thing. I didn't think that was the right way of doing things but it's interesting. Here's a patch that just sets the maxlength to 1024.

Not sure what was wrong with the last patch. I rolled that one on Windows so it's possible my line-endings were messed up?? And I used "cvs diff -up"...Anyway, here's another one rolled on OS X. All it does is change the maxlength on the tags textfield from 255 to 1024.

That's very bizarre. I'm not sure why it got hung up on that.

But cool! Committed to HEAD. Moving to 6.x for consideration.

Committed to 6.x, thanks! Looks like this can be backported to 5.x as well.

Committed to 5.x.