Needs review
Project:
shazamgallery
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 May 2006 at 22:49 UTC
Updated:
31 Aug 2006 at 20:22 UTC
Jump to comment: Most recent file
Comments
Comment #1
Bèr Kessels commentedThis patch is indeed far from clean.
Comment #2
ajwwong commentedyou're right. still just getting used to the patch thing. :-( probably shouldn't have submitted it.
good luck!
albert
Comment #3
Egon Bianchet commentedA clean patch
Comment #4
hitka commentedIn the current shazamgallery cvs version this is already fixed. It has one problem though -- the function not only got renamed, but it is now located in another module -- in image_gallery module.
It would be probably better not to be dependent on this module as shazamgallery is meant as a replacement of image_gallery. But if you need to have this dependency, you should also check for image_gallery module too as you check for image module and probably mention it in the README etc.
Comment #5
Bèr Kessels commentedwe we don't want to depnd on that module, indeed.
Comment #6
zach harkey commentedShould we duplicate this functionality e.g.
_shazamgallery_get_vid ()etc.? Or bite the bullet and depend on image_gallery? As it stands, it's been completely broken since May.Furthermore, if we do duplicate the functionality, should
_shazamgallery_get_vid()still get and set $image_gallery_nav_vocabulary or should it use a different variable like $shazamgallery_nav_vocabulary?Comment #7
zach harkey commentedOf course, now that I think about it, if you can't beat em...
Comment #8
Bèr Kessels commentedI vote for duplicating the code. No need to depend on a module for only one function. In addition, we need to change the variable names, because otherwise it will create unnecessary conflicts with image_gallery
Comment #9
Egon Bianchet commentedI duplicated the code. We still have to fix the form_alter because the vocabulary is showed both in categories and in the gallery fieldsets. The breadcrumb looks broken too ...
Comment #10
Egon Bianchet commentedFixed form_alter