If tests happen to pass then I will bench this. By the use of the (known to be very fast) array_pop function and [] operator, I have implemented a simple stack to remove the recurse from drupal_render.

CommentFileSizeAuthor
#10 drupal.render-ref.9.patch8.59 KBsun
#6 drupal_render_flatten_review.txt2.71 KBchx
#6 drupal_render_flatten.patch8.82 KBchx
#3 drupal_render_flatten.patch9.08 KBchx
#3 drupal_render_flatten_review.txt2.97 KBchx
#1 drupal_render_flatten_review.txt2.35 KBchx
drupal_render_flatten.patch8.46 KBchx

Comments

chx’s picture

chx commented
StatusFileSize
new drupal_render_flatten_review.txt2.35 KB

For easier review, I attached a patch without the whitespace changes.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

subscribing

chx’s picture

chx commented
StatusFileSize
new drupal_render_flatten_review.txt2.97 KB
new drupal_render_flatten.patch9.08 KB

Added lots of comments and a missing reference in the for header.

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
Issue tags: +Performance, +D7 API clean-up

.

chx’s picture

chx commented
Issue tags: -Performance, -D7 API clean-up
StatusFileSize
new drupal_render_flatten.patch8.82 KB
new drupal_render_flatten_review.txt2.71 KB

Replaced the ugly for loop with a much nicer do.

chx’s picture

chx commented
Status: Needs review » Needs work
Issue tags: +Performance, +D7 API clean-up

Oh well. I presume we need an output stack too.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.render-ref.9.patch8.59 KB

Note that #601806: drupal_render() should not set default element properties when #type is not known contains some further optimizations to drupal_render() is about to be committed. (boils down to: skipping empty elements and not setting any global defaults)

--

Playing around with this, I think it is more complex than it needs to be.

If you disagree, then at least take over the comments. ;)

Status: Needs review » Needs work

The last submitted patch failed testing.

Crell’s picture

Crell commented

Subscribing.

chx’s picture

chx commented

Sun, your approach is even more broken than mine :) I will take the comments, thanks.

chx’s picture

chx commented
Assigned: chx » Unassigned
Issue summary: View changes
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue tags: -D7 API clean-up +API clean-up

Official tag is "API clean-up" - https://www.drupal.org/node/1207020

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.