WebNewCastle [WebNewCastle]

1.       '#title' => 'Node Template',
         '#description' => 'Select the node template for this node',
   

   Title and description should be translatable.

2.       '#title' => t('Node Template Settings'),
   

   Strings used in user interface should have the first word in capital case, and the other words in lower case (with the exception of proper nouns, adjectives derived from proper nouns, and acronyms).

3.   $handler = opendir($theme_path);
     while ($file = readdir($handler)) {
       if ($file != '.' && $file != '..' && drupal_substr($file, 0, 4) == 'node') {
         $name = drupal_substr($file, 0, -8);  // name without .tpl.php
         $options[$name] = $name;
       }
     }
     closedir($handler);
   

   The code could use file_scan_directory().

4.     'description' => t('Custom Node Template table'),
   

   Schema description should not be passed to t(). See system_schema() for an example of what done by Drupal core code.

5. The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.
6. The uninstallation function should also remove the Drupal variables used by the module.

t() is mandatory for every string used in the user interface; the only cases where its use is not mandatory for third-party modules code is when the function is called from Drupal core code for those modules (see the case of the menu callbacks title, for which the string is passed to t() from Drupal core code).

file_scan_directory() returns an array of objects where each object represent a file (the function doesn't return directories).
Modules should use Drupal functions, when available.

Just to make an example, this is the result returned by file_scan_directory(drupal_get_path('theme', 'garland'), '.*\.tpl.php', array('.', '..', 'CVS'), 0, FALSE) (the result has been passed to var_export()):

 array (
  'themes/garland/block.tpl.php' => 
  stdClass::__set_state(array(
     'filename' => 'themes/garland/block.tpl.php',
     'basename' => 'block.tpl.php',
     'name' => 'block.tpl',
  )),
  'themes/garland/comment.tpl.php' => 
  stdClass::__set_state(array(
     'filename' => 'themes/garland/comment.tpl.php',
     'basename' => 'comment.tpl.php',
     'name' => 'comment.tpl',
  )),
  'themes/garland/maintenance-page.tpl.php' => 
  stdClass::__set_state(array(
     'filename' => 'themes/garland/maintenance-page.tpl.php',
     'basename' => 'maintenance-page.tpl.php',
     'name' => 'maintenance-page.tpl',
  )),
  'themes/garland/node.tpl.php' => 
  stdClass::__set_state(array(
     'filename' => 'themes/garland/node.tpl.php',
     'basename' => 'node.tpl.php',
     'name' => 'node.tpl',
  )),
  'themes/garland/page.tpl.php' => 
  stdClass::__set_state(array(
     'filename' => 'themes/garland/page.tpl.php',
     'basename' => 'page.tpl.php',
     'name' => 'page.tpl',
  )),
)

You could pass a callback name to the function, which would be a function that saves the result in a variable, after it processed the names of the file as your code does.

My point about using file_scan_directory() is still valid; the code is still using substr() when it should use the Drupal function.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.