AJAX 'changed' command asterisk argument doesn't work [#623310]

Due to a simple wording error, the second argument to ajax_command_changed() (to mark a div with an asterisk) doesn't work. The attached patch fixes it.

This is a followon to #544418: Integrate CTools AJAX framework with Drupal to extend (and replace) existing ahah framework, where this command was introduced.

Comment	File	Size	Author
#4	ajax_changed_command_fix_with_tests_623310_04.patch	3.59 KB	rfay
#4
	ctools_asterisk_bug_01.patch	343 bytes	rfay

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 4 November 2009 at 18:08

The Examples module AJAX Example now provides a testbed for this. Use the "AJAX Example: Advanced Commands" menu.

Comment #2

katbailey CreditAttribution: katbailey commented 13 November 2009 at 20:02

Status:

Needs review

» Reviewed & tested by the community

For anyone else looking at this, it's a hard one to test while this issue is still outstanding: #622922: User input keeping during multistep forms. ($form_state['values']['changed_command_example'] is always empty so the asterisk doesn't get added).

However, if I remove the dependency on anything in $form_state['values'] in the callback, I confirm that the asterisk does get added, whereas it doesn't without the patch.