CVS edit link for magicyril

Hello,

I created a module that permit to add some customization for blocks.
As Bluetrip CSS Framework (and Blueprint too) define a grid with 24 columns, this module allow the administrator to set a column size to any block, and to define a specific css class for any block.
This module define the UI, but the template need to be changed. The instructions are
defined in the README.txt file.

This module is quite specific but I thought it could be usefull for others.

CommentFileSizeAuthor
#4 bluetrip_block.zip5.28 KBmagicyril
#1 bluetrip_block.zip10.73 KBmagicyril

Comments

magicyril’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new10.73 KB

thanks.

avpaderno’s picture

Issue tags: +Module review
avpaderno’s picture

Status: Needs review » Needs work
  1.       'description' => t('Bluetrip settings.'),
    

    Schema description should not be passed to t() anymore.

  2.     $options['span-'. $i] = t('span '. $i);
    

    The first argument of t() is a literal string, not a dynamic value; differently, the script to extract the strings to translate will not extract the string.

  3.   if ($values['css_classes']) {
        $value .= ' '. check_plain($values['css_classes']);
      }
      bluetrip_block_save($name, $value);
    

    check_plain() is used when showing a string, not when saving it.

  4. The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.
magicyril’s picture

Status: Needs work » Needs review
StatusFileSize
new5.28 KB

Thanks for the feedback. I updated the code, and I deleted the LICENSE.txt file.

matt2000’s picture

Status: Needs review » Needs work

- You missed #1 above. it's in your hook_schema.

-You're still running check_plain() on input; you just moved it to a different function. check_plain() should only be run on output.

avpaderno’s picture

Status: Needs work » Closed (won't fix)

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes