Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
3 Nov 2009 at 16:52 UTC
Updated:
9 Oct 2019 at 07:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jrao commentedComment #2
avpadernoSee the Drupal coding standards to understand how a module code should be written.
See also what reported about the respect of the namespace, in the coding standards.
Comment #3
avpadernoThe coding standards report that there should be a space after the
if, and before the parenthesis.Comment #4
jrao commentedOk, code style cleaned up, but I'm not sure about the problem with namespace though, could you clarify? Thanks
Comment #5
avpadernoMenu callback titles, and description should not be passed to
t()because that is already done by Drupal core code.The code could use
module_load_include().The code could be written in a single line, as the line length would not be greater than 80.
If
0, andFALSEare not both two possible return values of the function, then the IF-statement could be re-written asif (!$field) {.When possible, avoid to escape the string delimiter inside strings, especially if they are translated; when the string delimiter is used inside the string, it is enough to use the other string delimiter to delimit the string.
In a HTML string, it is possible to use the tag
<q>to avoid to use the apices inside a string.Comment #7
avpaderno