I am translating the views module into Spanish and I have this sentence:

"If no search is performed and this field does not appear, pick an alternative default table sort field."

My doubt is if it does not contain an error and it should be:

"If a search is performed and this field does not appear, pick an alternative default table sort field."

Just to be sure, Thanks a lot.

Gustavo, from Madrid

CommentFileSizeAuthor
#8 views_handler_field_search_score.patch1.01 KBrschwab
#6 621794-views_handler_field_search_score.patch967 bytesesmerel

Comments

dawehner’s picture

dawehner
Primary language German
commented

If no search would be performened, there would be no result, so i guess also from code, that this should be "a".

Feel free to post a patch :)

esmerel’s picture

esmerel commented
Status: Active » Postponed (maintainer needs more info)

Where is that sentence?

dawehner’s picture

dawehner
Primary language German
commented
Status: Postponed (maintainer needs more info) » Active 
./modules/search/views_handler_field_search_score.inc:29:
esmerel’s picture

esmerel commented
Assigned: Unassigned » esmerel

I will see if I can figure out how to patch it. Later :D

myxelf’s picture

myxelf commented

Subscribing...

esmerel’s picture

esmerel commented
Status: Active » Needs review
StatusFileSize
new 621794-views_handler_field_search_score.patch967 bytes

I'm not sure this patch is correct, but it does change the line I wanted changed, so...

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

Actually the original text is correct. It could be reworded:

"If no search was performed causing this field to not appear..."

Basically what this means is that if there is not a search performed, the score will not appear. This setting forces an alternative default sort so that you don't have an arbitrary non sort when there isn't a score.

rschwab’s picture

rschwab commented
Status: Needs work » Needs review
StatusFileSize
new views_handler_field_search_score.patch1.01 KB

How about:

'Pick an alternative default table sort field to use when the search score field is unavailable.'

If this works for you guys the patch here implements it.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed to all branches.

Status: Fixed » Closed (fixed)
Issue tags: -spanish translation, -interface

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +spanish translation, +interface

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.