Thanks for this useful module.
I am wondering if there is a way to:
- remove user1 from the subscribe list display
- remove a specific role of users from the subscribe list display

Thanks,

Izzy

CommentFileSizeAuthor
#18 support-setting-user1-on-subscribe-list-621378-18.patch1.73 KBizmeez
#8 support-remove_user_1_option-621378-8.patch4.39 KBtinker

Comments

jeremy’s picture

jeremy commented
Status: Active » Postponed (maintainer needs more info)

What is your goal? To have them always subscribed? Or never subscribed?

izmeez’s picture

izmeez commented

Goals:

user1, never subscribed and userid not exposed to others

users in identified specific role; not visible for other roles to subscribe them but may view tickets and self subscibe. e.g. developer role

Sorry to mix two different issues in one ticket.

Thanks,

Izzy

izmeez’s picture

izmeez commented

I'm sorry that I included two different items in this issue.
I would like to refocus this issue to one item, how to remove user1 from the subscribe list.
Essentially, I would like to hide user1 and the userID for user1 from display throughout the site for security reasons.

Any thoughts on how to remove user1 from the subscribe list would be appreciated.

Thanks,

Izzy

jeremy’s picture

jeremy commented
Category: support » feature
Status: Postponed (maintainer needs more info) » Active

Unfortunately it is not currently possible, marking as a feature request.

izmeez’s picture

izmeez commented

+1 bump Still looking to remove user1 from subscribe list.

Are you looking for a patch to the module?

Maybe with option on /admin/support/settings/general to show or not show user1 on ticket subscribe.

spgd01’s picture

spgd01 commented

I also want to remove user 1 from assign list as well. No need for the site administrator to be assigned to things and to get notifications.

jeremy’s picture

jeremy commented
Status: Active » Patch (to be ported)

Feature added to 7.x-1.x-dev:
http://drupalcode.org/project/support.git/commit/72c7943

It needs someone to backport it to 6.x-1.x-dev...

tinker’s picture

tinker commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new support-remove_user_1_option-621378-8.patch4.39 KB

Backport to 6.x-1.x-dev attached.

izmeez’s picture

izmeez commented
Status: Needs review » Needs work

The patch in #8 does not work for me.
It applies without any problem but nothing seems to have changed.
User1 still shows on the "Subscribed" check box lists when adding a comment or editing a ticket.

tinker’s picture

tinker commented

@izmeez, Just to confirm
- You enabled the new option in settings
- You are not using uid 1 account when testing (you can always select yourself if you have permission)
- You are not using auto-complete fields (D7 patch did not fix this)

izmeez’s picture

izmeez commented
Status: Needs work » Needs review

my bad, did not enable the new option in settings.
Thanks it does work.

izmeez’s picture

izmeez commented

Sorry, I haven't yet looked at the Drupal 7 commit.

On the settings page in the option description, why is it necessary to show the user1 name in brackets?

Check this box to prevent the user with UID 1 (user1name) from showing up in ...

I think it would be better not to show the user1 name.
Does this would need to be put forward as a separate ticket?
Thanks.

tinker’s picture

tinker commented

@izmeez, I did a straight port so did not design anything. User needs 'administer support' to view the settings page so I don't think it's a big security breach to display the username there. If you feel differnetly then I guess since its already committed to 7.x-1.x-dev it would be a new ticket for the change.

izmeez’s picture

izmeez commented
Status: Needs review » Reviewed & tested by the community

@tinker Yes, I kind of thought it would need to be a new issue. Thanks for the back port.

jeremy’s picture

jeremy commented
Status: Reviewed & tested by the community » Fixed

Thanks!
http://drupalcode.org/project/support.git/commit/b334e4f

FWIW: I prefer showing the username of UID1 so there's no confusion about what you're doing. As noted earlier, only admins will see this configuration option.

izmeez’s picture

izmeez commented

With respect for the views expressed and this patch having resolved a feature request, I would like to open a separate issue on the question of displaying the username for UID1. Even though this is only visible to site admins when working with several sites and several different admins and developers we find it unnecessary for others to see the username of UID1 and feel it is more secure to avoid that behaviour. A separate issue might allow for further discussion. https://drupal.org/node/2008668

Thank you for backporting this patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

izmeez’s picture

izmeez commented
Issue summary: View changes
Status: Closed (fixed) » Needs work
StatusFileSize
new support-setting-user1-on-subscribe-list-621378-18.patch1.73 KB

Ironically, I actually got what I wanted but I cannot accept it and stay quiet.

I noticed that the commit to the 6.x branch noted in comment #15 is missing one piece from the back ported patch and the commit in the 7.x branch. That is the option on the support settings page to exclude user1 from the subscribe list.

Attached is a patch of the missing portion.

I didn't think it was appropriate to open a new issue and instead risked the cardinal sin of re-opening a closed issue.

izmeez’s picture

izmeez commented
Status: Needs work » Needs review

Corrected status.

  • Jeremy committed b334e4f on 8.x-1.x 
    feature #621378 backport by tinker, optionally filter uid1

  • Jeremy committed b334e4f on 8.x-1.x 
    feature #621378 backport by tinker, optionally filter uid1
purencool’s picture

purencool commented
Status: Needs review » Closed (outdated)