Wijering4 (JW Player) Doesn't Display Thumbnails [#620992]

I found I needed to make some changes to wijering4.module to get the thumbnail to work.

I change line 174-176 to :

if (isset($vars->othervars['image']) && !valid_url($vars->othervars['image'], TRUE)) {
$flashvars['image'] = '/' . $vars->othervars['image'];
}

It now works a treat!

David

Comment	File	Size	Author
#2	swftools-620992.patch	919 bytes	TravisCarden

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 November 2009 at 14:30

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #2

TravisCarden CreditAttribution: TravisCarden commented 11 May 2010 at 02:55

Title:	Thumbnail with JW Player	» Wijering4 (JW Player) Doesn't Display Thumbnails
Assigned:	dwkitchen	» Unassigned
Status:	Closed (fixed)	» Needs work

File	Size
swftools-620992.patch	919 bytes

Good job, @DavidPlanesTV. Let's roll a patch so we can get this fix into a release.

To bring everyone else up to speed here, the SWF Tools Wijering4 (JW Player) module doesn't display thumbnail images. As @DavidPlanesTV discovered, that's because wijering4.module is looking for it in $flashvars['image'] instead of $vars->othervars['image'] where it actually exists. I'm attaching a patch with his changes. They is a problem with them that needs to be addressed before it can be committed: they replace swftools_get_media_url(swftools_get_media_path() for the image path with merely '/'. I don't understand exactly what the former code was doing, but I take it it had something to do with handling the possibility of remote images, so we can't just remove it. Perhaps someone who knows better what's going on there can help us come up with a complete solution. For those who don't care about the lost functionality, you can use this patch in the interim.

Note that this problem exists in the 2.x branch as well, so the fix will need to be backported when it's finished.

Comment #3

Stuart Greenfield CreditAttribution: Stuart Greenfield commented 11 May 2010 at 19:13

Status:

Needs work

» Needs review

This is already fixed in 6.x-3.x.

I don't plan to go back and formally fix 6.x-2.x as the new release will replace it.

Just tested locally to double check and it's working ok.

Thanks for the patch anyway!!

Comment #4

semperos CreditAttribution: semperos commented 10 June 2010 at 15:59

Absolutely great work on this module, Stuart, but I'd just like to nudge here.

Just cost X amount of time and Y dollars to figure out that thumbnails aren't working w/JW, bc you haven't applied a few-line patch to the currently active and suggested version of the module.

Comment #5

mikeytown2 CreditAttribution: mikeytown2 commented 23 September 2010 at 20:17

Version:

6.x-3.x-dev

» 6.x-3.0-beta4

I'm using 3.0-beta4 and I can not get it to display thumbnails. Using the video module 4.1-rc4. If i use http://drupal.org/project/flowplayer then the thumbnail shows up.