This patch rewrites and removes some texts at the theme pages, as you can see in the screen shots.

Theme overview page before
Theme overview page after
Theme settings page before
Theme settings page after

CommentFileSizeAuthor
#6 themesadmindescription.png31.49 KBheather
#5 Picture 6.png31.49 KBheather
#5 Picture 6.png31.49 KBheather
#4 rewrite_theme_pages_02.patch5.79 KBxano
#2 rewrite_theme_pages_01.patch5.79 KBxano
rewrite_theme_pages_00.patch6.08 KBxano

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new rewrite_theme_pages_01.patch5.79 KB

I don't believe you, testing bot!

seutje’s picture

seutje commented
Status: Needs review » Needs work 
-      $output = '<p>' . t('Set and configure the default theme for your website.  Alternative <a href="@themes">themes</a> are available.', array('@themes' => 'http://drupal.org/project/themes')) . '</p>';
+      $output = '<p>' . t('Select the themes to use for this website. You can <a href="!settings">configure</a> site-wide display settings or configure themes individually. Note that different themes have different regions available for displaying data.', array('!settings' => url('admin/appearance/settings'))) . '</p>';

api page on t() suggests using @placeholder for urls

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new rewrite_theme_pages_02.patch5.79 KB

Roger.

heather’s picture

heather commented
StatusFileSize
new Picture 6.png31.49 KB
new Picture 6.png31.49 KB

I'm guessing you guys saw this issue : #504080: Improve Themes Admin Description The patch was committed only a few hours before this came out. Lengthy discussion on there.

At any rate, I tested this patch and I don't see the line that mentions contributed themes, as you show in your theme settings page 'after' screenshot.

[Edit: WEIRD, that is not my screenshot, lol. it was a dumb file name, ofc. but embedded it before upload, and obviously the name was taken]

heather’s picture

heather commented
StatusFileSize
new themesadmindescription.png31.49 KB

Screenshot *really* attached now!
themesadmindescription.png

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Oh, it should have been there :|

Leaving this marked needs review, so other people can take a look at it. I'll put the link back in first thing.

Bojhan’s picture

Bojhan commented

Can we restrict the scope of this patch to the settings page?

Bojhan’s picture

Bojhan commented
Status: Needs review » Closed (won't fix)

We fixed it already. If there is something specific about the settings page, please open an issue about that.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned