On admin/structure/taxonomy/1/list, if someone uses drag-and-drop to rearrange their vocabularies, then saves, there is no feedback message.

A drupal_set_message() should display a feedback message such as "Configuration saved."

This also affects the tags page, e.g. admin/structure/taxonomy/1/list (should it be a separate issue?)

This is v. similar to #609108: Menu admin page should say something when you save

Files: 
CommentFileSizeAuthor
#8 620592_taxonomy_admin_page_feedback.patch810 bytesSivaji
Passed on all environments. View
#4 620592_taxonomy_admin_page_feedback.patch1.44 KBSivaji
Passed on all environments. View
#3 620592_taxonomy_admin_page_feedback.patch1.45 KBSivaji
Passed on all environments. View

Comments

lisarex’s picture

Priority: Normal » Minor
Issue tags: +ui-text
webchick’s picture

Component: taxonomy.module » user interface text
Issue tags: -ui-text

Let's use this component rather than the tag. There are lots of other issues like this categorized this way.

Sivaji’s picture

Status: Active » Needs review
FileSize
1.45 KB
Passed on all environments. View

Attached is a patch which adds an if check and drupal_set_message() to submit handler of terms overview form (admin/structure/taxonomy/%tid) and vocabularies overview form (admin/structure/taxonomy), prints message like "Your configuration has been saved." when there are one or more changed items.

The same behavior exists in d6 so the patch need to be backported.

Sivaji’s picture

FileSize
1.44 KB
Passed on all environments. View

Rerolled #3 patch with appropriate variable name.

Sivaji’s picture

There is an another usability issue with Taxonomy admin page #641314: Taxonomy term form being rebuilt even after final submit, dropping the link here to get your attention.

lisarex’s picture

HI sivaji, applied the patch and it works great. If someone else with a codey background can also review and approve, we can get this RTBC'd...

Dries’s picture

To me, the $is_changed check feels unnecessary. Even if nothing was changed, it is useful to give a status message, IMO.

Sivaji’s picture

FileSize
810 bytes
Passed on all environments. View

+1 for #7. Re-rolled patch displays status message without any check.

webchick’s picture

Status: Needs review » Fixed

Awesome, thank you! :)

Committed to HEAD.

Any chance I could persuade you to look at #609108: Menu admin page should say something when you save while you're here? :D

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.