From http://drupal.org/node/610234#comment-2202806 :

6. The #id fragments on the permissions page do not work correctly in the overlay. So for example, if you click on "Help" in the toolbar, then "Taxonomy", then "Configure permissions", it takes you to the permissions page and then seems to flash you down to the correct (taxonomy) portion of the page, but then jumps you right back to the top of the page a second later. I assume this happens when the URL fragment parsing code kicks in, but not sure.

CommentFileSizeAuthor
#4 overlayanchors.patch734 bytescasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented
Title: Overlay: Existing URL fragments are broken » Existing URL fragments are broken
Component: other » overlay.module
Issue tags: -overlay

Retitling and un-tagging.

seutje’s picture

seutje CreditAttribution: seutje commented

looks like forcing the right src on $('#overlay-element') (entire path like http://example.com/foo#bar) seems to fix it, for FF 3.5.5 at least

note #567754: Wrong anchor adjustment in tableheader.js which might make it seem not to work

casey’s picture

casey CreditAttribution: casey commented

Reminder to write a patch for this.

casey’s picture

casey CreditAttribution: casey commented
FileSize
overlayanchors.patch734 bytes

Three-line-fix.

casey’s picture

casey CreditAttribution: casey commented
Status: Active » Needs review
ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented
Status: Needs review » Reviewed & tested by the community

Lovely. Another bug bites the dust.

seutje’s picture

seutje CreditAttribution: seutje commented

I guess that works too o.O

casey’s picture

casey CreditAttribution: casey commented

This is committed?

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented
Status: Reviewed & tested by the community » Fixed

right, http://drupal.org/cvs?commit=306108

seutje’s picture

seutje CreditAttribution: seutje commented
Title: Existing URL fragments are broken » doesn't scroll to the right position for URL fragments
Status: Fixed » Needs work

Is it possible that the height of the toolbar is counted twice?

clicking the permissions for image resulted in this which seems to be exactly the height of the toolbar

I apologise if this isn't the correct issue for this

casey’s picture

casey CreditAttribution: casey commented

You're right. we should substract sum of heights of elements with overlay-displace-top class.

casey’s picture

casey CreditAttribution: casey commented
Status: Needs work » Fixed

Should be fixed since #668640: Overlay shouldn't be based on jQuery UI Dialog.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

Is there any way a bright person here could fix this even without the overlay? if one goes to /admin/people/permissions#module-filter, the filter grouping is obscured by the toolbar. Its not that bad n perm page, but it gets debilitating in other places ... Sorry for the noise here.

casey’s picture

casey CreditAttribution: casey commented

#787940: Generic approach for position:fixed elements like Toolbar, tableHeader

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Priority: Normal » Major
Status: Closed (fixed) » Active

Its not fixed, and we have seen from various people in our module page interviews - that they consider this functionality useless due to it.

I am marking this major, because its a pretty important function of the module page and it now does not work.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Title: doesn't scroll to the right position for URL fragments » overlay doesn't scroll to the right position for URL fragments
Version: 7.x-dev » 8.x-dev
David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Version: 8.x-dev » 7.x-dev
Status: Active » Closed (fixed)

An issue for this regression was already opened a while ago at #1129578: Overlay doesn't respect internal anchor links.

Not sure if we need a dedicated issue (in the toolbar module) for Moshe's comment in #15...