I know they are working on this but here's a specific problem with the thumbs...

Thumbnails aren't being generated and when i edit a node and click the link to see the thumbnail the url it takes me to has some illegal characters in it: (the thumb_blah bit, not the xxxxxx's)

The requested URL /xxxx-xxxxxxxx.............xxxxxxxx_320x240_thumb_d.jpg was not found on this server.

I think it should be this, but this doesn't work either

The requested URL /xxxx-xxxxxxxx.............xxxxxxxx_320x240_thumb.jpg was not found on this server.

I think they are trying to generate multiple thumbnails and i'm guessing that the thumb_xx is going to be the number of the thumbnail. Which is a cool idea, but what's with the weird characters thumb_d.jpg?

CommentFileSizeAuthor
#5 cdn2_flowplayer.patch_1983 byteskylebrowning
#4 cdn2_flowplayer.patch983 byteskylebrowning

Comments

sphism’s picture

sphism commented

This is still a CRITICAL issue.

I thought it had been fixed last week with the updates you did, but alas not.

This really really needs to be fixed :(

kevster’s picture

kevster commented

Im having the same problem - transcoding seems to work fine now after recent hiccups but no thumbnails showing at all. This is the last stumbling block for us on an otherwise excellent module. Any news guys on a fix please?

sphism’s picture

sphism commented

Hello,

This is still a CRITICAL BUG, no thumbnails are being generated for any content and no one has replied to this issue...

erm... please give me some indication of when this will be fixed, at least just roll back the changes you've made and do your development work on a development system, NOT the live one.

Our site is waiting to go live and we are considering moving to a different system entirely.

Perhaps the module should be tagged as BETA since it currently doesn't work.

Other changes made recently have been great but you've got to provide thumbnails...

Good Luck,

matt

kylebrowning’s picture

kylebrowning commented
StatusFileSize
new cdn2_flowplayer.patch983 bytes

EDIT, dont use this patch, has bad formatting.

kylebrowning’s picture

kylebrowning commented
StatusFileSize
new cdn2_flowplayer.patch_1983 bytes

Apparently
Use this one.

--- cdn2_flowplayer/cdn2_flowplayer.module      6 Oct 2009 23:20:56 -0000       1.1.4.11
+++ cdn2_flowplayer/cdn2_flowplayer.module      10 Nov 2009 19:58:31 -0000      1.1.4.12
@@ -47,13 +47,8 @@ function theme_cdn2_flowplayer($node, $a
   $field_info = _cdn2_get_field_by_content_type($node->type);
   $name = $field_info['field_name'];
   $assets = $node->{$name}[0]['assets'];
-  foreach($assets as $new_asset) {
-    if($new_asset['preset_name'] == '320x240_thumb') {
-       $splash_image_file = '<img src="'. $new_asset['asset_fetch_url'] .'">';
-    }
-  }
+  $splash_image_file = preg_replace("%\.[^\.]*$%", "_thumb_009.jpg", $video_url);
 
-//  $splash_image_file = preg_replace('%_([^/]*)$%', '_'. $width .'x'. $height .'.jpg', $video_url);
   $flash_js = theme('cdn2_flowplayer_get_js',$node->nid, $preset->shortName, $player_path, $width, $height, $video_url, $splash_image_file);
   $top = ($height/2)-(46/2);
   $left = ($width/2)-(46/2);
kylebrowning’s picture

kylebrowning commented

Dont use the attachments, they have bad characters in them for some reason..

Use the stuff in < code >

sphism’s picture

sphism commented

Thank you so much Kyle. I'll try this out in the morning and get back to you.

sphism’s picture

sphism commented

Hmm, i'm not getting any thumbnails from the patch you supplied but it's quite possible that my custom code is getting in the way somewhere.

I updated to the latest dev release yesterday and applied your patch to that.

Can you please send me a link to a new style thumbnail that works and / or a description of how the url is formed from the data in the cdn2_videos table...

i think it's:

http://us.network3.cdn2.net/[our unique client code]/[video_token]_flash_flv_low_res_thumb_009.jpg

but currently this doesn't work???

kylebrowning’s picture

kylebrowning commented

Once the dev version has been re-generated try again.

I do believe I have fixed this now.

kylebrowning’s picture

kylebrowning commented
Status: Active » Fixed
sphism’s picture

sphism commented
Status: Fixed » Needs work

--deleted--

i think i can fix this myself...

sphism’s picture

sphism commented

Ok i got this working...

I really like that you are generating multiple thumbnails.

You have hard coded it to choose thumbnail 009 but we have short clips and they don't always get 9 thumbs, i changed it to the first thumb and it works great.

The reason i figured this out is that you haven't protected the parent directory from listing all it's files, please can you do this, i don't particularly want people being able to go and grab all the images and movies without using the site.

Sorry, i've changed this to needs work just so you check this post, feel free to set it back to fixed :)

Thanks for sorting this all out for us...

kylebrowning’s picture

kylebrowning commented

FYI, this will be committed to Dev later today.

http://skitch.com/kylebrowning/n8enm/test-demo.cdn2.net

sphism’s picture

sphism commented
Version: 6.x-1.9 » 6.x-1.x-dev
Priority: Critical » Normal
Status: Needs work » Fixed

Ah. That look great :)

kylebrowning’s picture

kylebrowning commented

Should be in dev snapshot as soon as its regenerated

sphism’s picture

sphism commented

All works very nicely, being able to select thumbnail on the node edit page is great.

Thanks for doing that.

matt

sphism’s picture

sphism commented
Status: Fixed » Needs work

aarahhaharrrr...

:)

So it turns out only $user->uid == 1 gets a thumbnail made for them.

If you add this permission to a module...

/**
 * Implementation of hook_perm()
 */
function mymodule_perm() {
  return array(
    'transcode cdn2 video to 320x240_thumb'
  );
}

then anyone you give that permission will get thumbs, which you want to be everyone.

ps i'm working on site with lots of overrides so it's possible that this is fixed but i haven't copied the right changes over to my over rides, but i'm pretty sure this isn't the case.

sphism’s picture

sphism commented

hmm...

ok, so the above fix does indeed show a tickbox for all users to generate a thumbnail but it doesn't actually get made on the server....???

Any ideas kyle?

sphism’s picture

sphism commented
Priority: Normal » Critical

Ok, well this is still an issue. The user with id = 1 gets thumbnails but no one else does.

Any ideas? Is it your end or my end? I can't bugfix your end and everything apart from the uid looks the same to me at my end...

I'm stumped.

matt

kylebrowning’s picture

kylebrowning commented

I did some work this morning on the module to support permissions for generating thumbnails.

I was able to test and confirm that thumbnails are being generated for a uid that is != 1

If you want, cvs checkout to get the latest changes, or you can wait till a new dev snapshot is generated

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Fixed
IncrediblyKenzi’s picture

IncrediblyKenzi commented

Note also that as of the latest dev release, the cdn2 thumb preset is deprecated, as 10 thumbnails are now generated per transcode format. The latest theming functions reflect this as well, and include the ability to select which thumbnail you wish to use.

-=Aaron

sphism’s picture

sphism commented

Just updated to latest dev release (nov25) and can confirm that the thumbnails are working for everyone.

Thanks for that, and thanks for the other new features as well.

matt

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.