Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I just noticed, that there is a section called "messages" in core which contains one single function: http://api.drupal.org/api/HEAD/function/message_na
I really think that this one is pretty unnecessary. I attached a patch where all occurences of this function have been replaced with t('n/a').
Comment | File | Size | Author |
---|---|---|---|
#5 | message_na_contrib.patch | 23.08 KB | kkaefer |
#1 | message_na_0.patch | 3.71 KB | kkaefer |
message_na.patch | 3.43 KB | kkaefer | |
Comments
Comment #1
kkaefer CreditAttribution: kkaefer commentedI still don't see any reason why this function should stay there. Updated the patch.
Comment #2
kkaefer CreditAttribution: kkaefer commentedComment #3
fgmIt is currently in use in various modules, some of them important. Removing it would mean patching them too:
Comment #4
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Marking this 'code needs work'. Set to 'fixed' when this change is documented in the upgrade instructions. Thanks timcn.
Comment #5
kkaefer CreditAttribution: kkaefer commentedMade a patch for contrib CVS to replace message_na() with t('n/a'). This should not break anything, even with non-HEAD versions.
Comment #6
kkaefer CreditAttribution: kkaefer commentedThanks to killes, the change is no documented on the corresponding handbook page.
Comment #7
Dries CreditAttribution: Dries commentedComment #8
(not verified) CreditAttribution: commented