Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
30 Oct 2009 at 13:25 UTC
Updated:
9 Oct 2019 at 07:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mesh commentedkindly let me know what other information do i need to submit to support the application.
Comment #2
mesh commentedtheme files are attached.
Comment #3
mesh commentedi ran the theme through the coder module, and updated it to coding standards. see attached.
Comment #4
avpadernoRemember to change the status, when you upload new code.
Comment #5
avpadernoThe code can be better written as
Adding a new line character will probably result in having a new line in the middle of the ID declaration.
The delimiter used at the end of the instructions should not be omitted in lines like
print $terms, which should be written asprint $terms;.Comment #6
avpadernoComment #7
mesh commentedi have updated the same, and re-attached the theme.
Comment #8
mesh commentedignore the earlier attachment. i checked the code for line-end-delimiters, and made changes as required. theme attached..
Comment #9
avpadernoI forgot to report that files available from third-party sites should not be committed in CVS. In this case, it is true for some JavaScript files.
The rest is fine.
Comment #10
mesh commentedyes, i suppose this is true for the jScrollpane, and other jquery plugins. what would be the best way to include them, then?
Comment #11
avpadernoThe only way is to report to the users they need to download a file, where they can download it, and where they need to put it.
Comment #12
mesh commentedcreated a theme how-to file (readme.txt), and removed the scripts from the package.
Comment #13
mesh commentedComment #14
avpadernoThe file should be named README.txt.
Comment #15
mesh commentedsmoothly commited files to the cvs repository. but i am not able to branch it (i suppose it is required to make a release) also that how does the project page get created?
Comment #16
avpadernoYou first need to create the project page for the theme, and then you can create the branches.
If you have problems on creating it, I can create it for you.
Comment #17
avpadernoComment #18
mesh commenteddone. thanks a lot for your help, KiamLaLuno!
Comment #21
avpaderno