CVS edit link for mesh

We have created a custom Drupal theme for a particular site. We would like to make it publicly available. Also, doing this would allow people to contribute to it and enhance it further.

the theme can be seen in action at http://northeastwestsouth.net

CommentFileSizeAuthor
#12 newskin.zip18.89 KBmesh
#8 newskin.zip24.39 KBmesh
#7 newskin.zip24.39 KBmesh
#3 newskin.zip24.4 KBmesh
#2 newskin.zip24.28 KBmesh

Comments

mesh’s picture

kindly let me know what other information do i need to submit to support the application.

mesh’s picture

StatusFileSize
new24.28 KB

theme files are attached.

mesh’s picture

StatusFileSize
new24.4 KB

i ran the theme through the coder module, and updated it to coding standards. see attached.

avpaderno’s picture

Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Theme review

Remember to change the status, when you upload new code.

avpaderno’s picture

<div id="node-<?php print $node->nid; ?>" class="node<?php if ($sticky) { 
  print ' sticky'; 
} ?><?php if (!$status) { 
print ' node-unpublished'; } 
?>">

The code can be better written as

<div id="node-<?php print $node->nid; ?>" class="node<?php if ($sticky): ?> sticky<?php endif; ?>  <?php if (!$status): ?>node-unpublished<?php endif; ?>

Adding a new line character will probably result in having a new line in the middle of the ID declaration.

The delimiter used at the end of the instructions should not be omitted in lines like print $terms, which should be written as print $terms;.

avpaderno’s picture

Status: Needs review » Needs work
mesh’s picture

Status: Needs work » Needs review
StatusFileSize
new24.39 KB

i have updated the same, and re-attached the theme.

mesh’s picture

StatusFileSize
new24.39 KB

ignore the earlier attachment. i checked the code for line-end-delimiters, and made changes as required. theme attached..

avpaderno’s picture

Status: Needs review » Needs work

I forgot to report that files available from third-party sites should not be committed in CVS. In this case, it is true for some JavaScript files.

The rest is fine.

mesh’s picture

yes, i suppose this is true for the jScrollpane, and other jquery plugins. what would be the best way to include them, then?

avpaderno’s picture

The only way is to report to the users they need to download a file, where they can download it, and where they need to put it.

mesh’s picture

StatusFileSize
new18.89 KB

created a theme how-to file (readme.txt), and removed the scripts from the package.

mesh’s picture

Status: Needs work » Needs review
avpaderno’s picture

Status: Needs review » Fixed

The file should be named README.txt.

mesh’s picture

Status: Fixed » Active

smoothly commited files to the cvs repository. but i am not able to branch it (i suppose it is required to make a release) also that how does the project page get created?

avpaderno’s picture

You first need to create the project page for the theme, and then you can create the branches.
If you have problems on creating it, I can create it for you.

avpaderno’s picture

Status: Active » Fixed
mesh’s picture

done. thanks a lot for your help, KiamLaLuno!

Status: Fixed » Closed (fixed)
Issue tags: -Theme review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.