Closed (fixed)
Project:
E-mail This Page
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 May 2006 at 05:26 UTC
Updated:
16 Nov 2006 at 19:13 UTC
Jump to comment: Most recent file
Comments
Comment #1
lanesharon commentedGoogle is still 'seeing' these nodes in this format, but I am using clean url's. So, mine show up as:
http://www.gates-chili-high.org/emailpage&nid%3D97
In my error logs, as I mentioned here already. Why Google can read them, I have no idea. When I am not signed in, I do not get the emailpage link, so how can Google?
This has me baffled!
Comment #2
millerrd commentedHere's some fixes for the url problem. in emailpage.module update the following lines:
line 50:
$links[] = l(t('email this %type', array('%type' => t($e_l_t))), "emailpage", array('title' => EMAIL_PAGE_TITLE), "nid=$node->nid");
line 54:
$links[] = l(t("email this ".$e_l_t), "emailpage", array("title" => EMAILPAGE_TITLE), "nid=$node->nid"); return $links;
Comment #3
seaneffel commentedThis fixed my problem, has it been submitted for permanent fix yet?
Comment #4
dewolfe001 commentedCloser, but I found a bug in the URL is gave up.
When I tried to use the emailpage it gave me a gimped up URL:
http://example.com/drupal//drupal/?q=en/node/19
when I really wanted:
http://example.com/drupal/?q=en/node/19
so, in emailpage,module on lines 76 and 78, I changed it from this:
$base_url .'/'.to this:
$host['scheme']."://".$host['host'].That seemed to patch it up so that it works now.
Comment #5
casperl commentedThis is the same bug described in http://drupal.org/node/89028
Comment #6
drummHere is a patch to fix this issue. The problem was improperly using the l() function.
Comment #7
darren ohComment #8
davemybes commentedPatch works perfectly for me. Thanks for that.
Comment #9
darren ohThis patch is not relevant to the latest release.