Need a Save & Add Fields button when adding a content type

So I am wondering, if this is part of the editing, or the creating a new content type workflow. I am to argue that since we will have Manage fields on content type page, it should not be part of editing a content type.

Here ya go. I tried to follow other button text patterns and so used "and" instead of "&" and sentence capitalization.

Can anyone who sees this tell me if there's already an issue regarding the fact that you lose the breadcrumb when you go to edit a content type? You can't click straight back to the list of content types.

Also, is it a new thing to have return statements at the end of form submit handlers? They seem quite unnecessary...

(Forgot to set to "needs review." Also, the patch is for an include in the node module folder, so I tweaked the component.)

Bah, and I just realized why this was marked for the fields_ui.module. Should've dawned on me sooner that this wouldn't be so simple... for those following along at home, this button should only show if the Field UI module is enabled. Gonna have to work it into that module as a form alter instead of this painless patch. : P

I'd like to see this in before UX freeze. It'd definitely make the workflow here much smoother.

Here is a patch based on #4, moved to field_ui.module

I tested this patch and it seems to work just fine. The code looks good too.

Yeah, I agree with that. Let's put it there only on add.

Also, that $form_state['build_info']['args'][0]->type thing looks weird. It looks like $form has a #node_type index that'll work for this?

Attached an updated version of #9.
Changes:
- Based on #12, changed $form_state['build_info']['args'][0]->type to $form['#node_type'].
- Added a new check in submit handler, because previous versions of patch redirected regardless which submit button was clicked.
- Updated comments (periods and capital letters).

Forgot to mark as patch...sorry.

Oh, so testing bot is re-checking attached patches, so there's no need to re-attach it. :)
My bad...anyway, please review it.

Worked as described:

• At initial content type creation, adds a button labelled "Save and add fields".
• Upon clicking the button the user is taken to the fields manager page.
• Editing an existing content type doesn't have the "Save and add fields" button.

Anyone else want to review it?

This looks great, and really speeds up the interaction users are going to want in about 8/10 of the cases.

I made one teensy tweak which was to change:

if ($form['#node_type']->type === "") {

to:

  if (empty($form['#node_type']->type)) {

The first is perfectly correct, but we use empty() more often than not for legibility.

Committed to HEAD!

@webchick Wohoo!
Thanks for enlightening me. This was my first commit to Drupal and it feels really great! :)

Sorry to jump in late.

+    $form_state['redirect'] = 'admin/structure/types/manage/'. $form_state['values']['type'] .'/fields';

This needs to be strtr('_', '-', $form_state['values']['type']);, or this will break if the node type name has a _.
Ya know, the 'underscore to dash' conversion for node types in URLs we all love ;-)

Er, or even better:
$form_state['redirect'] =_field_ui_bundle_admin_path('node', $form_state['values']['type']) . '/fields';

Adjusted the patch according to #20.
Although I tried and it works with '_' too, but it's definitely more consequent.

Ah, good catch, yched. Committed to HEAD.

zserno: CONGRATS on your first core patch! WOOT! :D

Little follow-up: #1665920: "Save and add fields" should be "Save and manage fields"