Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Oct 2009 at 09:49 UTC
Updated:
9 Oct 2019 at 07:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
alex72rm commentedHi,
I attached the 5.x version of my italian stemmer module.
Comment #2
avpadernoComment #3
alex72rm commentedHi again,
I have removed LICENSE.txt and applied some minor modification to code.
stem.class.php is a freely re-distributable class written by a colleague that asked me to cite his work.
I did it, as I imported class into .module code.
Comment #4
avpadernoSee the Drupal coding standards to understand how a module code should be written.
The coding standards contain a section about the string functions that a module needs to use.
Comment #5
alex72rm commentedHi,
I have applied all the 'normal'-option code modification suggested by "coder" contributed module.
I hope it's the right direction...
Comment #6
avpadernoThe module is supposed to use Drupal Unicode functions that handle multibyte strings; this means it should use
drupal_strlen()rather thanstrlen(), etc.Comment #7
avpadernoThe coding standards also report how to format code; the above code is not formatted as suggested.
Comment #8
alex72rm commentedHi,
@#6: ok
@#7: I've applied some modifications, but I'm not sure to have accomplished the work as desired.
Comment #9
alex72rm commentedComment #10
alex72rm commentedAny news?
Comment #11
avpadernoIF-statement should be written as
Check also the indentation that in some cases seems to not be correct (for each indentation, you should add or remove two spaces).
Comment #12
alex72rm commentedHi again,
I've applied all your considerations concerning code style optimization.
I would ask if you prefer to check 6.x version too, before publishing attached 5.x version.
Thanks!
Comment #13
avpadernoThe code should be use
drupal_strpos(). There are some minor formatting issues (i.e.,$ante_suff_len-drupal_strlen($ante_b)should be re-written as$ante_suff_len - drupal_strlen($ante_b); see the Drupal coding standards for more details).The variables should be named using English words; the same is true for the comments.
Comment #14
alex72rm commentedHi again,
thanks for your review.
I'll go forth to improve the module.
A comment: drupal_strpos() doesn't exist.
Comment #15
avpadernoThat is true; I always get confused with
drupal_substr().Your application has been approved; you can start creating your project when you want.
Comment #17
avpaderno