“SimpleTest error collector” tests fail when verbose logging is enabled

Works for me, thanks :)

Let's get an inline comment to explain that change related to verbose messages.

I'm also confused about the API change to assertError(). If anything I'd think you'd change it to $message = '', since that's what most of the other assertion messages seem to be doing.

#5: simpletest-verbose-3.patch queued for re-testing.

To catch other debug messages as well, we could test for $group == 'User notice', which is the group used for debug and verbose messages.

... but as it's only used locally, why bother :)

#839068: DrupalErrorCollectionUnitTest fails in Verbose mode has been marked as duplicate, but seems to contain a simpler approach. This patch adds proper comments, so it's preferred. However, whichever approach makes more sense needs discussion. To be solved in this issue.

We were also confused by this same bug at #930812: Testing is stalled due to failing simpletest tests, where justinrandell posted a nearly identical patch to DamZ's in #839068...

Anyway, yeah, DamZ's approach for this is cleaner than #5, so I re-rolled it to remove fuzz and get a fresh bot result for RTBC and commit...

It looks like the last time I reviewed this patch, i marked it cnw for comments, and lo and behold I am doing the same now. ;)

+    if ($group != 'User notice') {

Why explicitly exempt "User notice"?

+    else {
+      parent::error($message, $group, $caller);
+    }

A one-liner explaining what happens in the "else" case would be nice, since the if branch has it.

one-liner?! as if. ;) to actually explain WTF is happening here requires a small novel...

Sorry, emacs failure -- I accidentally capitalized "Protected" without meaning to. Also, the collectedErrors array is protected, not private, to this class.

Yeah, yeah....

Fixed a typo in one of the comments and added that debug() is treated the same way as verbose(). Still RTBC, IMHO. ;)

Well! That was way more than I was asking for, but YAY! :) Nicely done.

Committed to HEAD.

And by that I mean...

@webchick: Cool, thanks. ;)