Rewrite outdated references to taxonomy_term_node [#609140]

This might already be a bug, but I couldn't find it.

At any rate, when you do so, you get this little piece of loveliness:

Firey death

"PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table '7x.taxonomy_term_node' doesn't exist: SELECT COUNT(*) AS expression FROM {node} n INNER JOIN {users} u ON n.uid = u.uid INNER JOIN {taxonomy_term_node} tn0 ON n.nid = tn0.nid WHERE (tn0.tid = :db_condition_placeholder_0) ; Array ( [:db_condition_placeholder_0] => 1 ) in PagerDefault->execute() (line 86 of /Users/webchick/Sites/drupal/includes/pager.inc)."

This appears to be yet another critical error that testing bot isn't finding, since I'm pretty sure we have test coverage for this area of the code. If not, let's make sure we add some. ;)

Comment	File	Size	Author
#6	609140_rewrite_taxonomy_term_node.patch	9.91 KB	mcarbone
#6

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

timalsina CreditAttribution: timalsina commented 21 November 2009 at 06:27

Yes, I am also having this issue on latest build (11/20/09). The testing bot isn't finding it.

Comment #2

Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented 27 November 2009 at 10:42

+1
I can reproduce the same here with latest build.

Comment #3

mcarbone CreditAttribution: mcarbone commented 1 December 2009 at 02:11

Title:

If you filter by taxonomy term at admin/content, the world ends in firey death

» Rewrite outdated references to taxonomy_term_node

Looks like there are several outdated references to taxonomy_term_node, which after #412518: Convert taxonomy_node_* related code to use field API + upgrade path is no longer of our world.

modules/node/node.admin.inc:137: $query->join('taxonomy_term_node', $index, "n.nid = $index.nid");
modules/node/node.module:1549: $query->join('taxonomy_term_node', 'tn', 'n.vid = tn.vid');
modules/search/search.api.php:157: $query->join('taxonomy_term_node', 'tn', 'n.vid = tn.vid');
modules/taxonomy/taxonomy.tokens.inc:126: $sql = "SELECT COUNT (1) FROM {taxonomy_term_node} tn WHERE tn.tid = :tid";
modules/taxonomy/taxonomy.tokens.inc:180: $sql = "SELECT COUNT (1) FROM {taxonomy_term_node} tn LEFT JOIN {taxonomy_term_data} td ON tn.tid = td.tid WHERE td.vid = :vid";

Comment #4

mcarbone CreditAttribution: mcarbone commented 1 December 2009 at 02:12

Title:

Rewrite outdated references to taxonomy_term_node

» Rewrite outdated references of taxonomy_term_node to field API

Comment #5

mcarbone CreditAttribution: mcarbone commented 5 January 2010 at 23:14

Title:	Rewrite outdated references of taxonomy_term_node to field API	» Rewrite outdated references to taxonomy_term_node
Assigned:	Unassigned	» mcarbone

Two things:

1) We can use the denormalized taxonomy_index table to rewrite these.

2) Two of these have already been handled by #610022: Taxonomy Tokens: Fix old queries, so we only have to fix the first three.

modules/node/node.admin.inc:137: $query->join('taxonomy_term_node', $index, "n.nid = $index.nid");
modules/node/node.module:1549: $query->join('taxonomy_term_node', 'tn', 'n.vid = tn.vid');
modules/search/search.api.php:157: $query->join('taxonomy_term_node', 'tn', 'n.vid = tn.vid');

Assigning to myself to take these on.

Comment #6

mcarbone CreditAttribution: mcarbone commented 7 January 2010 at 01:29

Status:

Active

» Needs review

File	Size
609140_rewrite_taxonomy_term_node.patch	9.91 KB

Patch rewrites the outdated queries, fixes a couple of small bugs involving advanced search by terms that popped up along the way, and adds tests for filtering by terms when searching, and on the content administration page.