pm530 [pm530]

See the Drupal coding standards to understand how a module code should be written.

1. ; Information added by drupal.org packaging script on 2008-06-02
   version = "6.x-1.2"
   core = "6.x"
   project = "userpoints_best_answer"
   

   Remove that information, which is added by the packaging script.

2.     'title' => t('User Point Best Answer Settings'), 
   

   Menu title and description are not passed to t() because that is already done by Drupal core code.

3. There is a problem with the line ending character, that in some places seems to be the one used by Windows.

4.       if ($award_points < 0) {
           form_set_error('', t('Invalid.'));
         }
   

   The error message is too generic; the users cannot understand what is wrong.

   If the error is not caused by the users, then showing such message can just confuse them. In the case that value is negative, it could be better to do as it is zero; the code could register the error using watchdog().

5.   $award_points =(int) $award [0] ['value'];
   

   The line should be formatted as $award_points = (int) $award[0]['value'];.

   Generally speaking, when the code access the index of an array, the code should be written as $array['index'], without any spaces between.

See point #5 in my previous comment; there are code lines that still use code like $a ['index'] = $value. The space between the variable name, and the open square bracket needs to be removed.