DickSwart [DickSwart]

1. Most files miss the CVS ID tag, or have the CVS ID tag from another Drupal.org user.

2. // The code for conditional stylesheets started out as a patch for synfox. Now that
   // it has been spun out to its own separate module, It would be nice to prevent
   // code drift between the synfox implementation and the conditional_styles.module,
   // so synfox now includes an exact copy of conditonal_style module's
   

   The theme should not include the file of another module, especially if this module is already included in Drupal.org CVS. There is also another reason to not include it: the respect of a module/theme namespace.

/**
 * Implements HOOK_theme().
 *
 * We are simply using this hook as a convenient time to do some related work.
 */
function _synfox_theme(&$existing, $type, $theme, $path) {}

The function is not really an implementation of hook_theme(); the name of a hook doesn't include the starting underscore character, and Drupal would not use that function as hook.

See the code of the Drupal function which invokes all the implementation of a particular hook passed as argument.

function module_invoke_all() {
  $args = func_get_args();
  $hook = $args[0];
  unset($args[0]);
  $return = array();
  foreach (module_implements($hook) as $module) {
    $function = $module .'_'. $hook;
    $result = call_user_func_array($function, $args);
    if (isset($result) && is_array($result)) {
      $return = array_merge_recursive($return, $result);
    }
    else if (isset($result)) {
      $return[] = $result;
    }
  }

  return $return;
}

You will notice that the function name is built using $module .'_'. $hook.

  // Modify elements of the search form
  $vars['form']['search_theme_form']['#title'] = t('');
 
  // Set a default value for the search box
  $vars['form']['search_theme_form']['#value'] = t('Search this Site');

An empty string is always an empty string, whatever language is used. The code should rather pass to t() the string that reports the copyright.

When I change the status to fixed, it means that I approved the CVS account. Sometimes I make some notes about some changes to implement in the code; you can make those changes before committing the code in CVS.

Welcome aboard!

There is no reason to delete the project. You can remove the files committed, and start again.