taxonomy_field_formatter_load() should use taxonomy_term_load_multiple() [#606114]

This will
# allow RDF to inject stuff into the default field formatter.
# allow taxonomy module to take advantage of entity-level caching from http://drupal.org/project/entitycache and it's own internal cache if terms are loaded elsewhere in the page.
# get rid of a direct query for taxonomy_term_data() since we have so few now it's a shame to leave any in.
# allow themers to do stuff in the field templates without writing a new formatter.

Comment	File	Size	Author
#4	term_load.patch	1021 bytes	catch
	term_load.patch	1.17 KB	catch

Comments

Comment #1

catch

he/him

English

commented 16 October 2009 at 04:21

Status:

Active

» Needs review

Comment #2

dawehner

German

commented 16 October 2009 at 17:41

I read

-    // Avoid calling taxonomy_term_load_multiple because it could lead to
-    // circular references.

Can you explain why this does not lead to circular references?

Comment #3

17 October 2009 at 04:45

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #4

catch

he/him

English

commented 17 October 2009 at 05:09

Status:

Needs work

» Needs review

Status	File	Size
new	term_load.patch	1021 bytes

hook_field_load() could lead to circular references, hook_field_formatter_prepare_view() doesn't - that comment was left over from before #493314: Add multiple hook for formatters went in.