CVS edit link for rashad612

Yamli is a JavaScript tool that works as Arabic Character conversion tool and Smart Arabic Keyboard.
The idea behind it, is to convert Latin written letters into Arabic letters.
It works with form input elements ( text fields and textareas ). So, as users type, Yamli starts to convert the input letters into recognized Arabic words.

This module is actually a wrapper module for the Yamli JavaScript tools, it intends to integrate this tool into Drupal. The module has an admin settings page, for global settings and configurations as admin settings form.
And a per user setting, to enable or disable the service based on user's preference.

The source code is downloadable from here: http://yamli.untitledlabs.com/sites/yamli.untitledlabs.com/files/yamli.t...

CommentFileSizeAuthor
#3 yamli.tar_.gz3.28 KBrashad612
#1 yamli.tar_.gz3.31 KBrashad612

Comments

rashad612’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new3.31 KB

The attached module.

avpaderno’s picture

Status: Needs review » Needs work
  1. 	 '#description' => t('For more details about Yamli Settings, please visit !link', 
    	    array('!link' => l('Yamli API Documentation', 'http://www.yamli.com/api/docs', array('absolute' => TRUE))))
    

    l() is not used together t(); that is reported in the documentation page for t(), which reports the following text:

    Here is an example of incorrect usage of t():

    $output .= t('<p>Go to the @contact-page.</p>', array('@contact-page' => l(t('contact page'), 'contact')));
    

    Here is an example of t() used correctly:

    $output .= '<p>'. t('Go to the <a href="@contact-page">contact page</a>.', array('@contact-page' => url('contact'))) .'</p>';
    
  2. Check the indentation, which in some cases is not 2 spaces as it should be.
  3. The code, in some cases, is not formatted as the coding standards report.
  4. For one line comments, use //, not #.
rashad612’s picture

Status: Needs work » Needs review
StatusFileSize
new3.28 KB

This is the module attached with the required modifications.
Thanks.

avpaderno’s picture

Status: Needs review » Fixed

Strings used in the user interface should be written like IDs and classes; the first word is in capital case, while the others are in lower case (except when the word is an acronym, or a proper noun).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.