IE6.css is not added to the page when I looked at it in IE6 and Firefox

I made a patch based on how Garland adds the IE specific css to the page.

This patch is needed for #569516: D7UX: Make list icons in admin interface clickable

CommentFileSizeAuthor
template.php_.patch714 bytesp.brouwers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rickvug’s picture

Issue tags: +quickfix

Before:
<!--[if lt IE 7]><style type="text/css" media="screen">@import '

After:
<!--[if lt IE 7]><link type="text/css" rel="stylesheet" media="all" href="

This looks fine for me. Its been a while since debugging IE6, but I do remember it being fussy about how stylesheets are added.

rickvug’s picture

Issue tags: -quickfix +Newbie, +Quick fix

updating tags

nkmani’s picture

Status: Needs review » Reviewed & tested by the community

Applying the patch, makes following lines now show up in the head section:

Without the patch, these lines are missing (probably because of the wrong key used in seven_process_html() for $vars)

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

p.brouwers’s picture

Status: Needs work » Needs review

patch failed somehow, resubmitting

p.brouwers requested that failed test be re-tested.

roborn’s picture

Status: Needs review » Reviewed & tested by the community

@rickvug yeap, the css works just fine that way.
The problem was the incorrect path to the css, plus there was no html.tpl override to add the $ie_styles var.

This patch fix this issue.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

How I long for the day I can mark this issue "by design"... :\

That code's a bit hard to read with all the various "\n"s in there, but I confirmed that that's how Garland does it as well. The exception was that Garland uses path_to_theme() instead of drupal_get_path(...) so I switched that.

Committed to HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Newbie, -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.