CVS edit link for langecornu

I am currently developing a module (DivX Publisher Pack) to allow Drupal users to add DivX video content to their site (AVI and MKV container).

To module will use Drupal's hook to create the content, select the thumbnail to use and display the node containing the clip.

The clip will be playable using DivX Web player.

My motivation is to provide content creator and publishers that operate a Drupal based website, tools to easily publish and manage their creations on their site.

CommentFileSizeAuthor
#17 Publisher's_Handbook_1_1_1.pdf463.16 KBlangecornu
#12 divxpublisherpack-6.x-1.0.1.zip24.88 KBlangecornu
#8 divxpublisherpack-6.x-1.0.1.zip25.76 KBlangecornu
#1 divxvideo-6.x-1.0.0.zip25.51 KBlangecornu

Comments

langecornu’s picture

langecornu commented
Status: Postponed (maintainer needs more info) » Needs work
StatusFileSize
new divxvideo-6.x-1.0.0.zip25.51 KB

This is not ready to be released yet, it is a development Snapshot

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
  1. Files available from third-party sites should not be included in Drupal.org CVS.
  2. See the Drupal coding standards to understand how a module code should be written.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Module review
langecornu’s picture

langecornu commented

Hi Kiam

What file are you referring to?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented 
<?php
/**
 * Class UploadProgressManager
 * 	This class is dedicated to my AJAX / PHP upload progress method, look at this page
 *      to know more about upload progress: http://www.devpro.it/upload_progress/
 *
 * @author              Andrea Giammarchi
 * @site				www.devpro.it
 * @date                2005/09/22
 * @lastmod             2005/09/22 13:30
 * @version             0.1 stable 
 */

Probably, also the other .php files are available from third-party sites too.

langecornu’s picture

langecornu commented
Status: Needs review » Needs work

No I create the other .php file but i used this file created by Andrea Giammarchi and used with his permission, only this one was not made by me

I left his header only to give him credit on that class.

Andrea released this class under MIT License (http://www.opensource.org/licenses/mit-license.php)

Peraps, I should just remove the header in the file

langecornu’s picture

langecornu commented
StatusFileSize
new divxpublisherpack-6.x-1.0.1.zip25.76 KB

Updated file

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Peraps, I should just remove the header in the file.

Removing the header doesn't change who is the author, or the fact the file is available from third-party sites.
Files licensed under a license different from GPL License v2+ should not be committed in Drupal.org CVS.

langecornu’s picture

langecornu commented

Maybe I can make some modifications to the file since I am allowed to do so anyway under MIT Licence, I will submit a corrected version.

"Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so"

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

You can edit it, but you cannot change the license under which the file is released.

If then it would be just a question of editing a file, I could edit the files of the jQuery UI, and commit all of them.
The fact they are available from third-party sites doesn't change, even if I would edit them.

langecornu’s picture

langecornu commented
StatusFileSize
new divxpublisherpack-6.x-1.0.1.zip24.88 KB

I found another way to do it without using this class

Here is an updated version

langecornu’s picture

langecornu commented

Please keep in mind this is only a pre-alpha version, not yet ready to be released.

It will be thoroughly tested before releasing it.

Thank you again and have a good week end :)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Remember to change the status, when you upload new code.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I would actually love to see a little collaboration between this and http://drupal.org/project/filefield considering FileField is now included in Drupal 7 core and is the module for uploading images/files/video.

langecornu’s picture

langecornu commented
Status: Needs review » Needs work

Yes Dave, I am considering this already.

I just wanted to avoid having a dependency on another module in order to work to make it as broadly available as possible. The Release for version 7 will definitely use the filefield features.

langecornu’s picture

langecornu commented
Component: Miscellaneous » Documentation
Status: Needs work » Needs review
StatusFileSize
new Publisher's_Handbook_1_1_1.pdf463.16 KB

Here is also my first draft at the user guide that will accompany the module.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Actually it looks like there is Divx support in http://drupal.org/project/video which seems to be quite active and supported. Also found documentation on how to migrate from Video to FileField with Divx support at http://drupal.org/node/298835.

At this point I'm leaning toward declining the application based on the fact that we want to encourage coordination and cooperation instead of duplication. I'll let someone else agree with me first before that decision is made however.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Documentation » Miscellaneous

I agree with Dave (how many times don't I agree with him?).

We tend to avoid duplication, and that is clearly stated on Apply for contributions CVS access.

langecornu’s picture

langecornu commented
Status: Needs work » Needs review

This Drupal module will be part of a product we will release (We as DivX) which will include a drupal module, a wordpress plug-in and a joomla module. We really want to have a Drupal version in the pack, it would be very unfortunate if we cant.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

@langecornu: Could you please try out the video.module and explain why and how your module is different then? We like to encourage cooperation and coordination instead of duplication. It's a big part of being a contributing member of our community.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

I am changing the status as per previous Dave's comment.

langecornu’s picture

langecornu commented

I installed the video module to evaluate in what ways our module is different from that one.

First, I like to say , the video module is great, it offers a lot of possibilities and accept many formats.

The main difference is that we want to offer a module that is more mainstream than this one. We want to offer a plug-in that is very easy to install, to use and doesn’t have much 3rd party dependencies.

Our version not only support DivX file in AVI container but Also DivX Plus file (Matroska container).

We also offer the user to adjust all the available options specific to webplayer:

• Minimum version required to play the current media (example 2.0 is required to play mkv)
• Webplayer control type (or webplayer skin)
• Parameter to allow(or prevent) user of right clicking on the player(contextual menu)
• Multiple choice for the buffering mode of the player
• Enable(or disable) looping at the end of the playback
• Enable(or disable) auto playback
• Enable(or disable) the DivX ad Post plate at the end of the video
• Change the over lay message(and Fontsize) ex.: “Click Here to Start Playback”

If the user don’t change theses values, optimal default values will be used.

Unlike the video module, if FFMPEG is installed on the server, our module automatically generate a choice of 3 images thumbnails for the user to choose from.

We also want to make sure our module is easy to install/use so non experimented user can install it on their server, even if this is their first module. We never know, some user might even want to start using Drupal because this module enable them to publish their creation easily.

Here is our desired Flow for the installation.

  • User Download the module
  • User extract the file
  • User upload the extracted file to their Drupal module folder on their server
  • User enable the module form the admin option
  • User starts to publish videos

Here is the flow for the current video module available from Drupal.org.

  • User download the module
  • User extract the file
  • User upload the extracted file to their Drupal module folder on their server
  • User go to the module administration page in his Drupal installation
  • User see there are 10 new components under the video section of the module administration

    • (If we target user that have minimal knowledge of the technology, they will have hard time to figure out what components are required or not in order of the module to work. Let say we use commonsense and we select(or try to select the followings: Video, URL Video, Upload Video, Video ffmpeg Helper, Video Image, Video Opt Metadata, Video Params)
    Unfortunately, selection cannot be done because these components have dependencies on other modules. (For many non-experiences user this will be a show stopper), Let say we continue

  • User returns on Drupal.org and find/download dependency : ‘Image module”
  • User extract the file
  • User upload the extracted file to their Drupal module folder on their server
  • Return on Drupal.org and find/download dependency : ‘Token module”
  • User extract the file
  • User upload the extracted file to their Drupal module folder on their server
  • User return to the module admin section of his Drupal installation.
  • User can now enable the following:
    • Image
    • Token
    • Video
    • URL Video
    • Upload Video
    • Video ffmpeg Helper
    • Video Image
    • Video Opt Metadata
    • Video Params
  • User is prompted to enter a Default image Path
  • User can now use the module
langecornu’s picture

langecornu commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Module 'Foo' is just too complex so I have written a much simpler version. This is just straight duplication of functionality and applications like this will almost certainly be declined. It is worth remembering that many modules start out simple also and, over time, grow into more complex systems. If you have the know how to write a "simple version" from scratch rather than work out how a complex module works then maybe your effort would be better spent making the existing complex module easier to use (improve it's UI, write documentation, etc).

I am not saying that the application will be rejected, but it seems the case is the one reported in Apply for contributions CVS access.

langecornu’s picture

langecornu commented

It's not just because this module is simpler, But the fact that all features can be managed using this module such as:

• Minimum version required to play the current media (example 2.0 is required to play mkv)
• Webplayer control type (or webplayer skin)
• Parameter to allow(or prevent) user of right clicking on the player(contextual menu)
• Multiple choice for the buffering mode of the player
• Enable(or disable) looping at the end of the playback
• Enable(or disable) auto playback
• Enable(or disable) the DivX ad Post plate at the end of the video
• Change the over lay message(and Fontsize) ex.: “Click Here to Start Playback”

and also support the management and publishing of the DivX Plus File (.mkv)

As I mentioned before, the module will be offered for most used CMS System such as Drupal, Wordpress, Joomla etc.. and will offer all the same features for all of them and one of the key feature will be easy to install/use.

Thank you again :)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

In your previous comment, you underlined the fact the users need to take more steps, in order to make the existing module working as they expect; this sounds like saying that the existing module is too complicated to be used from users, which is what Apply for contributions CVS access talks of.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work 
/**
 * Define Constants used in the module
 */
define('DIVXVIDEO_BLOCK_VIDEO',0);
define('DIVXVIDEO_IMPLEMENTATION','ffmpeg');
define('VALID_MEDIA_FILE_EXTENSION','divx|avi|mkv'); //use pipe (|) to separate supported format
define('INCLUDE_RELATIVE_PATH',drupal_get_path('module', 'divxvideo').'/includes/');
define('DIVX_FILE_FOLDER_PATH',str_replace('//','/',dirname($_SERVER['PHP_SELF'])."/sites/default/files/". variable_get('divxvideo_video_directory', 'divx') . '/'));
define('DIVX_FILE_FOLDER_PATH_RELATIVE',str_replace('//','/',"/sites/default/files/". variable_get('divxvideo_video_directory', 'divx') . '/'));
define('DIVX_FILE_FOLDER_PATH_LOCAL',str_replace('//','/',dirname($_SERVER['SCRIPT_FILENAME'])."/sites/default/files/". variable_get('divxvideo_video_directory', 'divx') . '/'));
define('INCLUDE_ABSOLUTE_PATH',str_replace('//','/',dirname($_SERVER['SCRIPT_NAME'])."/".INCLUDE_RELATIVE_PATH));
define('DRUPAL_ROOT_LOCAL_PATH',dirname($_SERVER["SCRIPT_FILENAME"]).'/');

/**
 * Load External javascript
 */
drupal_add_js(INCLUDE_RELATIVE_PATH."js/util.js",'file');
drupal_add_js(INCLUDE_RELATIVE_PATH."js/uploadProgress.js",'file');  //for the upload progress

/**
 * Initialize JS
 */

$jsCmd="var watcherLocation='".$GLOBALS['base_root'].INCLUDE_ABSOLUTE_PATH."fileProgressWatcher.php';";

drupal_add_js($jsCmd,'inline');  //for the upload progress*/

/**
 * Load the CSS
 */
drupal_add_css(INCLUDE_RELATIVE_PATH."/css/dpp-style.css");

Apart the code for defining new constants, the rest should be put in a Drupal hook (Drupal has a hook that can be used during initialization).

See the Drupal coding standards to understand how a module code should be written. In the coding standards there is a part about namespace respect.

langecornu’s picture

langecornu commented

Thank you for that, I am fixing some bugs now as I received some feedback from users that are testing the module, I will add this to my fixes :)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.