form and submit classes are overwritten conflicting with uc_out_of_stock and may be other modules [#604234]

I can't seem to get this module working at all on my site. After doing what seemed like the logical flow of selling/buying an item and it not working, I decided to do a test: I took 4 items, set the stock setting to "active", and then set them to different stock/threshold numbers:
stock 0, threshold 1
stock 1, threshold 1
stock 0, threshold 0
stock 1, threshold 0

Sadly, in all 4 instances I still have an "add to cart" button... What am i doing wrong??

The group i'm setting this up for sells only one of each item, so we need to get this piece working so 2 customers can't buy the same thing...

If anyone has any suggestions, i'd be MORE than happy to hear them :)

Thanks!

My hope was that ONE of those combinations wuo

Ubercart version: 6.x-2.0-rc7
Out of stock notifcation version: 6.x-1.4
drupal version: 6.13

Comments

Comment #1

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 14 October 2009 at 20:58

have you properly set the active checkbox? anyway, I can't seem to be able to reproduce this, and you seem to be the only one reporting it so far.

Do you have your dev or test site published somewhere so I can take a look, can you give me a temp admin pw of that demo to browse it and check some things?

a.=

Comment #2

angusmccloud CreditAttribution: angusmccloud commented 14 October 2009 at 21:54

Settings and test site address sent through your contact form.

The active checkbox is definitely checked on all the items.

If you can't figure it out I can probably hack around it by using contemplates and checking for the quantity before deciding to display the form -- but that's clearly a very "hack" solution, and I'd rather do it through here :)

Comment #3

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 15 October 2009 at 02:27

Title:	Isn't working on our site	» form and submit classes are overwritten conflicting with uc_out_of_stock and may be other modules
Project:	Ubercart Out of stock Notification	» Ubercart AJAX Cart
Version:	6.x-1.4	» 6.x-1.0-rc9
Category:	support	» bug

@angusmccloud: I took a look at your site. It seems that you have a conflicting module installed (uc_ajax_cart) which changes the classes of the actual add to cart form on the products, and thus, the JS of this module fails to properly find all the inputs.

I think that the issue is 100% on the other module, so I am moving this issue there. Because this module does not really change the ubercart form, but was actually design to work with the out of the box ubercart, there's not much I can do. While I can 'make it work', this is a very specific use case and I believe the fix should be on the uc_ajax_cart module.

Basically, I believe the uc_ajax_cart should change the original form as little as possible, and if it has to add new classes, they should be appended.

As I don't use that module I don't have the time to test both together properly, but I took a look at the code and I think the problem (it may not be the only one) is at line:396 of the uc_ajax_cart.module (using version 6.x-1.0-rc9):

    $form['submit']['#attributes'] = array_merge($form['submit']['#attributes'],array('class' => 'ajax-submit-form'));
    $form['#attributes'] = array_merge($form['#attributes'],array('class' => 'ajax-cart-form ajax-cart-form-kit'));

That bit is overwriting the form and submit classes, where they should be really 'appended'

a.=