The summary for the vocabularies fieldset shows "No terms", whether vocabulary terms are selected or not. Likewise, the Flags fieldset summary shows "No flags" at all times.

CommentFileSizeAuthor
#1 vertical_tabs-601260-flags-summary-fix.png21.6 KBandrewmacpherson
#1 vertical_tabs-601260-vocab-summary-fix.png26.73 KBandrewmacpherson
#1 vertical_tabs-601260.patch1.19 KBandrewmacpherson
vertical-tabs-flags-summary-bug.png18.58 KBandrewmacpherson
vertical-tabs-vocab-summary-bug.png24.08 KBandrewmacpherson

Comments

andrewmacpherson’s picture

andrewmacpherson commented
StatusFileSize
new vertical_tabs-601260.patch1.19 KB
new vertical_tabs-601260-vocab-summary-fix.png26.73 KB
new vertical_tabs-601260-flags-summary-fix.png21.6 KB

Here's a patch to fix it. Two jQuery selectors were at fault, looking for div elements instead of fieldset.

andrewmacpherson’s picture

andrewmacpherson commented
Status: Active » Needs review

forgot to update status with the patch

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Good catch. RTBC.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS (http://drupal.org/cvs?commit=285300). Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gooddesignusa’s picture

gooddesignusa commented

Sorry to reopen. Still seems to be an issue. Happened to me today with 6.x-1.0-rc1. Not sure if its taxonomy super select causing it since i didn't have time to test. Not really a big deal.

cybermache’s picture

cybermache commented
Status: Closed (fixed) » Needs work

I am also using 6.x-1.0-rc1. I originally thought it was an issue with Taxonomy Super Select. It still could be, I am not quite sure.

Turning off TSS outputs the fieldset title of the vocabulary followed by the terms in the vertical tab. Turning TSS on again only displays 'No Terms' in the vertical tab if all Vocab groups have TSS selected for them. Perhaps this has something to do with how VT is calling the terms and how TSS is outputting that value.

I am not using Flags so I can not confirm if this has the same affect. If this is indeed a TSS issue please let me know so I can post this issue there.

Thanks

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Closed (fixed)

If a module changes the way the taxonomy forms work, then it needs to provide its own summary JavaScript file.

cybermache’s picture

cybermache commented

Thanks for the response Dave. Could you possibly elaborate on your statement? Or if you don't feel like doing that can you suggest where my inquiry might receive more help?

Is this be something that should get posted to the TSS issue feed? For example.

Thanks