Brian294 [brian294]

You need to upload the code here; keep in mind we review just a module / theme per applicant.

1.     '#default_value' => empty($edit['activitystream_linkedin_feed']) ? '' : check_plain($edit['activitystream_linkedin_feed']),
       '#description' => t('For more information on how to acquire your Private URL, please visit: <a href="http://yadadrop.com/drupal-modules/linkedin-activity-stream" target="_blank">yadaDROP\'s LinkedIn help page</a>.'));
   

   There is no need to use check_plain() with data passed to functions of form API.

2. function theme_activitystream_linkedin_item($activity) {
     $node = node_load($activity->nid);
     $date = theme('activitystream_date', $node->created);
   

   The code loads the node data, but does the code check if the user has permission to see those node data?

3.   if ($label == '') {
       $label = t(check_plain(ACTIVITYSTREAM_LINKEDIN_DEFAULT_LABEL));
     }
   

   The first argument of t() must be a literal string, not a dynamic value.

1. ; Information added by drupal.org packaging script on 2009-03-01
   version = "6.x-1.x-dev"
   core = "6.x"
   project = "activitystream_linkedin"
   datestamp = "1254885917"
   

   That text needs to be removed, as it is added from the packaging script. I don't see any reason to add it; the module works the same without, and the module cannot have it if it has not been submitted in Drupal.org CVS.

2.   $name = theme('activitystream_username', $user);
     $label = check_plain(variable_get('activitystream_linkedin_label', ACTIVITYSTREAM_LINKEDIN_DEFAULT_LABEL));
   
     return '<span class=\"activitystream-item\">'. theme('activitystream_linkedin_icon')   . " <span>$name$label" . l($node->title, $activity->link) ." <span class=\"activitystream-created\">$date</span></span>". l('#', 'node/'. $node->nid, array('class' => 'permalink')) .'</span>';
   }
   

   Strings presented to the user must be translatable.

3.   if (!node_access('view', $node)) {
       return; // if current user has no access to node, exit.
     }
   

   A theme function should always return a value, even if it would be an empty string.

    $user->feed = $user->feed;

What is the purpose of that code line? In PHP, it doesn't do anything, if not assigning to $user->feed the value it already has.

  return '<span class=\"activitystream-item\">'. theme('activitystream_linkedin_icon')   . " <span>$name" . t($label) . l($node->title, $activity->link) ." <span class=\"activitystream-created\">" . t($date) . "</span></span>". l('#', 'node/'. $node->nid, array('class' => 'permalink')) .'</span>';

The first argument of t() must be a literal string, not a dynamic value; passing a dynamic value to t() is like not calling it at all (that means, nothing is translated). If the alternative is this code, then it is better to remove the call to t().