Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are a lot of cleanups to do in contact.module to help bring this up to documentation and conding standards.
Comment | File | Size | Author |
---|---|---|---|
#9 | 599186-contact-cleanup-D7-2.patch | 27.43 KB | Dave Reid |
#7 | 599186-contact-cleanup-D7.patch | 28.3 KB | Dave Reid |
#6 | 599186-contact-cleanup-D7.patch | 28.3 KB | Dave Reid |
#4 | 599186-contact-cleanup-D7.patch | 24.77 KB | Dave Reid |
#3 | 599186-contact-cleanup-D7.patch | 24.76 KB | Dave Reid |
Comments
Comment #1
Dave ReidJust a few things so far...so much to clean up.
- Renames vague functions like contact_admin_categories() and contact_admin_edit() to contact_category_list() and contact_category_edit_form(). Much easier to tell what each function does.
- Simplified the logic in contact_category_edit_form().
- Cleans up contact_load() for simpler code.
- Cleans up message variables in contact_mail().
Comment #3
Dave ReidComment #4
Dave ReidThank god for simpletest. Patch with 100% less stupid mistakes.
Comment #6
Dave ReidARG. Wrong patch.
Comment #7
Dave ReidFixed a few spelling errors.
Comment #8
Dries CreditAttribution: Dries commentedNo link is added so the comments looks incorrect.
Otherwise this looks like a nice clean-up.
Comment #9
Dave ReidRe-rolled for recent commits and removed that comment.
Comment #10
Dries CreditAttribution: Dries commentedCommitted. Thanks for the reroll.