Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Anonymous (not verified)
Created:
7 Oct 2009 at 10:33 UTC
Updated:
7 Oct 2019 at 12:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedAttached is the current version of the theme although I will add the baseline grid JavaScript as it looks here: http://baselinecss.com/
Comment #2
timmillwoodNote: I have been working with Benn on all our latest projects to get him up to speed with Drupal theming. I second his CVS application.
Comment #3
avpadernoFiles available from third-party sites should not be included in Drupal.org CVS.
Files that are not compatible with GPL License V2+ are not acceptable in Drupal.org CVS.
Comment #4
Anonymous (not verified) commentedI could commit it without the baseline files and state in the documentation that the files would need to be downloaded.
Comment #5
avpadernoThat is fine.
No new code has been uploaded.
Comment #6
Anonymous (not verified) commentedThanks, here are the new files.
Comment #7
avpadernojquery.autofill.js is available from third-party sites.
Then, why do the JavaScript files contain
// $Id: jquery.autofill.js,v 1.1.4.1 2009/08/05 18:55:54 add1sun Exp $, and// $Id: javascript.js,v 1.1.4.2 2009/08/12 23:29:56 add1sun Exp $?The file readme.txt should be renamed README.txt.
Comment #8
Anonymous (not verified) commentedI have removed the JavaScript files, added ; $Id$ to the .info file and renamed the README.text
Comment #9
avpadernoThe directories images, and styles need to contain at least one file (you can put a file README.txt to explain what they are for); differently, who will download the archive file created by the packaging script will not have those directories.
Comment #10
avpadernoComment #13
avpaderno