pegleglax [pegleglax] [#596776]

I'll be contributing both modules and themes. This message will be short and to the point for your time's sake.

Here is a site (theme) I'm developing at the moment: dev.estatesandtrusts.net/faqs
I gave you a link to the FAQ page because that's gotten the most attention so far.

Other D6 sites I've build on drupal:
activize.com
worldclassdealerservices.com
upperbuckssertoma.com
ryanelliottcustomhomes.com
and more...

The maintainer of the FAQ_Search module has agreed to add me as a co-maintainer. This will be a good starting point to familiarize with CVS.

I've been in the contrib queue's a lot though... submitting bug fixes and improvements.

My main focus will be on contributing PROFESSIONALLY designed themes. Drupal (to date) has no "really" good looking corporate themes. I also have 3 VPS's (hosted with rackspace) where I do all my development and hosting.

I don't know what you're expectations are for "approving" my CVS access... I can provide far more detail if necessary.

Thanks :)
Ben

Comment	File	Size	Author
#7	danyilaw.zip	650.58 KB	bensnyder
#1	danyilaw.zip	619.11 KB	bensnyder

Comments

Comment #1

bensnyder commented 6 October 2009 at 00:46

Status:

Postponed (maintainer needs more info)

» Needs review

Status	File	Size
new	danyilaw.zip	619.11 KB

The upload I included is a work in progress. It can be demoed at (dev.estatesandtrusts.net).

This theme won't be directly contributed as it is for a client but a slightly modified version will be. The list of sites I included above also will be modified and contribed.

I also will be co-maintaining FAQ_Search for starters.

Comment #2

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 6 October 2009 at 13:30

Issue tags:

+Theme review

Comment #3

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 October 2009 at 10:47

Status:

Needs review

» Needs work

jQuery.js is already included with Drupal; third-party modules (or themes) should not include it. This is generally true for files that are available from third-party sites.

Files committed in CVS should then be licensed under GPL v2+, not compatible licenses.

Comment #4

bensnyder commented 7 October 2009 at 11:51

Status:

Needs work

» Needs review

Funny you caught that - but it wasn't included in the .info file anyway :)
I removed it - must have copied it in there by accident.

Please remember that this theme is a work in progress at the moment but should be completed within a week. My main reason for needing a CVS account ATM though is for co-maintaining the FAQ_Search module.

After being a member for 2 years and active on d.o. on a daily basis, how hard can it be to get a CVS account? Thanks for the prompt attention.

Comment #5

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 October 2009 at 12:11

Status:

Needs review

» Needs work

If you need a CVS account to co-maintain an existing module, then the procedure to follow is different.

You have not uploaded new code.

Comment #6

bensnyder commented 7 October 2009 at 12:12

Ok then one sec. I'll grab my latest.

Comment #7

bensnyder commented 7 October 2009 at 12:19

Status:

Needs work

» Needs review

Status	File	Size
new	danyilaw.zip	650.58 KB

Ok -

The following is what I have to date (I actually worked through the night tonight ;).

I am only providing it since you want to see the code. But save yourself some time and check out the development live:
dev.estatesandtrusts.net

What exactly do I have to meet here to get approved? Are you just looking to make sure I don't have any licensed material?

As for the co-maintainership, what would you like me to do. Post a support issue asking for the approval by comment? That's what seemed to work for another user.

Comment #8

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 October 2009 at 12:26

Status:

Needs review

» Needs work

Files committed in CVS should be licensed under GPL v2+, not under compatible licenses. Then, files that are available on third-party sites should not be committed in Drupal.org CVS.

As for the co-maintainership, what would you like me to do. Post a support issue asking for the approval by comment?

You should open a support request offering to become co-maintainer; if the current maintainer accept your offer, then you can apply for a CVS account (in the application you need to report the link to the support request you opened). If you decide for this option, then this report will be closed.

Comment #9

bensnyder commented 7 October 2009 at 12:37

Files committed in CVS should be licensed under GPL v2+, not under compatible licenses. Then, files that are available on third-party sites should not be committed in Drupal.org CVS.

Ok that's fine. I can write an install guide where I instruct users to download certain libraries to make the theme work.

Do I need to have this theme "ready to commit" for the CVS account to get approved? I am only providing the uploaded theme as proof for the time being that I am serious about contributing. If so (which is incredibly inconvenient), then I will certainly pursue the co-maintainer route as it is less of a hassle.

Comment #10

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 October 2009 at 12:45

Do I need to have this theme "ready to commit" for the CVS account to get approved?

CVS applications are not usually approved, if the reviewed code contains some problems that need to be resolved before the code is committed; one of many problems I can think of is the presence of files that are available on third-party sites, or files not licensed under GPL license.

Comment #11

bensnyder commented 7 October 2009 at 12:59

Ok well here's my dilema.

I wan't to get the CVS account taken care of ahead of time.
I'm developing the theme as we speak and it should be ready within a week.
While developing, I have to have all the code in the theme.
The theme I uploaded is not what I'm 100% what I'm committing. It is simply a working example.
Once the theme is complete, I will then remove ALL 3rd party code and write instructions in a INSTALL.txt for downloading the aforementioned code.
Files not licensed under GPL will not be included either. But, then will be referenced in the INSTALL.txt.

Now my question is, can you approve my CVS account ahead of time, seeing as I have provided more than enough proof that I am a valid and serious contributor who is aware of all the concerns you have carefully outlined. Or....... Do we need to wait until I am done developing the theme so I can strip it of all 3rd party and non-GPL code?

Thanks for your prompt replies :)

P.S. In case this doesn't go anywhere, I created a support request for co-maintainership that should get replied to within the next 12 hours I expect.
#598106: Co-maintainership request for FAQ_Search

Comment #12

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 October 2009 at 13:05

As far as I know, we don't approve a CVS application ahead the time. Differently, what should be the purpose of this application, if the applicant just show a fragment of what it will be the committed code? You could add a security vulnerability, and the CVS application would be already approved.

If you want time to develop the theme you are submitting for the CVS application, you have two weeks from now to complete it. Generally, we close an application if there isn't new uploaded code after two weeks.