kpbowler [kpbowler]

1. Remove any files that are not released under GPL; compatible licenses are not accepted in Drupal.org CVS.

2.   $form['player'] = array(
       '#type'				=> 'fieldset',
       '#title'			=> t('Add a Profile'),
   

   In Drupal, only the first word is capital case; the other words are lower case.

3. function player_install() {
     drupal_install_schema('player');
     variable_set('player_global_profile_name', 'Global Profile');
     variable_set('player_global_tag', 'player');
     variable_set('player_global_flashvars', '');
     variable_set('player_global_attributes', '');
     variable_set('player_global_params', 'allowFullScreen = true
   allowscriptaccess = always
   wmode = opaque');
     variable_set('player_global_extras', '');
     variable_set('player_default_extras_width', '320');  
     variable_set('player_default_extras_height', '240');
     variable_set('player_default_extras_version', '9');
     variable_set('player_default_div', 'audio_jw_player');
     variable_set('player_count', 0);
   }
   

   There is no need to set Drupal variables to a default value.

4.   $schema['player_profiles'] = array(
       'decription' => t('Stores information about each profile'),
   

   Descriptions should not be passed to t() anymore; here there is another error too.

5.   define(CDN_DEFAULT_SERVER, 'http://'.$_SERVER['SERVER_NAME']);
   

   Constants defined from the module must respect the namespace; here there is another error too.

6. See the Drupal coding standards to understand how a module code should be written.

is point three and error?

The second paramenter of variable_get() is the value returned by the function when the Drupal variable has not been already set (in other words, it's the default value for the Drupal variable). It's perfectly useless to set a Drupal variable to its default value when variable_get() accepts a value that is used as default value.

Remember to change the status, when you upload new code.

1. The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.

2.         $msg = t('Player Profile Added.');
   

   It should Player profile has been added.

3.   if ($error) {
       drupal_set_message(t('There was an error.', 'error'));
     }
   

   The error message is not useful.

4. The file player.theme.inc can be merged with the module file; there is no reason to use a file for just a function.

5.   if ($sql && $headers) { 
       return generate_table($sql, $limit, $headers, $build_callback, $options_callback);
     }
     else {
       drupal_set_message(t('You must specify the SQL and the array of headers for the table.'), 'error');
     }
   

   If the error is not caused by input given by the user, then the error message should be avoided.

6. Any strings that are shown in the user interface should be translatable.
7. See the Drupal coding standards to understand how a module code should be written.

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.