abthemes.com [abthemescom]

We just review a module/theme per applicant. Please choose a theme, and that will be reviewed.

Remember to change the status, when you upload new code.

1. There are many files that are duplicated, and placed in different directories.
2. Remove the files that are not licensed under GPL license; compatible licenses are not accepted in Drupal.org CVS.

/**
* DD_belatedPNG: Adds IE6 support: PNG images for CSS background-image and HTML <IMG/>.
* Author: Drew Diller
* Email: drew.diller@gmail.com
* URL: http://www.dillerdesign.com/experiment/DD_belatedPNG/
* Version: 0.0.7a
* Licensed under the MIT License: http://dillerdesign.com/experiment/DD_belatedPNG/#license
*
* Example usage:
* DD_belatedPNG.fix('.png_bg'); // argument is a CSS selector
* DD_belatedPNG.fixPng( someNode ); // argument is an HTMLDomElement
**/

Also, jquery.lazyloaad.js is available from third-party sites, and it should not be added in Drupal.org.

function phptemplate_settings($saved_settings) {

  // Only open one of the general or node setting fieldsets at a time
  $js = <<<SCRIPT
    $(document).ready(function(){
      $("fieldset.general_settings > legend > a").click(function(){
      	if(!$("fieldset.node_settings").hasClass("collapsed")) {
          Drupal.toggleFieldset($("fieldset.node_settings"));
      	}
      });
      $("fieldset.node_settings > legend > a").click(function(){
      	if (!$("fieldset.general_settings").hasClass("collapsed")) {
          Drupal.toggleFieldset($("fieldset.general_settings"));
      	}
      });
    });
SCRIPT;
  drupal_add_js($js, 'inline');

It should be better to put that JavaScript code in a separate file. It would be also better to use Drupal behaviors.

The CSS file being used comes from a third-party site; in that case, it should not be included in CVS. The file then doesn't report the license under which is being licensed.

1. sliding_effects.js is another file that I guess is available from third-party sites.

2.     	<div class="cm-author"><?php print $author ?></div>
           <div class="cm-date">Posted <?php  print format_date($comment->timestamp, 'custom', 'F d, Y'); ?> at <?php  print format_date($comment->timestamp, 'custom', 'g:i a'); ?></div>
           <div class="content">
   

   Strings used in the user interface should be translatable.

3. The files style.css could be better formatted; as it is, it is difficult to read.

4.     <!-- ads -->
   	<div id="ads_above_btspl" class="adblock clearfix">
       	<a target="_blank" title="Drupal themes" href="http://abthemes.com/"><img width="125" height="125" alt="Drupal themes" src="http://drupal6.abthemes.com/ab_gallery/files/abadsdemo/abthemes.jpg"/></a>
   		<a target="_blank" title="iPhone wallpapers" href="http://iphone.abthemes.com/"><img width="125" height="125" alt="iPhone wallpapers" src="http://drupal6.abthemes.com/ab_gallery/files/abadsdemo/iphonewallpaper.jpg"/></a>
           <a target="_blank" title="Easy way to find web resource, web collections" href="http://hellocollections.com"><img width="125" height="125" alt="Easy way to find web resource, web collections" src="http://drupal6.abthemes.com/ab_gallery/files/abadsdemo/hellocollections.jpg"/></a>
           <a target="_blank" class="adhere" title="Advertise Here" href="#">Advertise Here</a>
           <a target="_blank" class="adhere" title="Advertise Here" href="#">Advertise Here</a>
           <a target="_blank" class="adhere" title="Advertise Here" href="#">Advertise Here</a>
           <a target="_blank" class="adhere" title="Advertise Here" href="#">Advertise Here</a>
   	</div>
   	<!-- //ads -->
   

   Is there an advertising section?

5. <!-- Footer -->
   <div id="ab-footer">
   	<div class="ab-btwrap clearfix">
           <div id="ab-footer-l">
           	Copyright 2009 <a href="#">Chris Wallace</a>. All Rights Reserved.<br />
   			Theme provided by <a href="http://abthemes.com" title="Abthemes">Abthemes</a>
           </div>
           <div id="ab-footer-r">
           
           </div>
       </div>
   </div>
   <!-- //Footer -->
   

   I read the copyright is held from Chris Wallace. Are you sure you can use the HTML you put in the templates?

6.     $title = t(variable_get('site_name', ''));
       $slogan = t(variable_get('site_slogan', ''));
       $mission = t(variable_get('site_mission', ''));
   

   The first argument of t() needs to be a literal string, not a dynamic value.

7.     $date = t('Posted ') . format_date($vars['node']->created, 'medium');                 // Format date as small, medium, or large
       $author = theme('username', $vars['node']);
       $author_only_separator = t('Posted by ');
       $author_date_separator = t(' by ');
   

   Rather than concatenating string, it would be better to use the placeholders the function uses.

8. The code is supposed to use the Drupal Unicode functions whenever possible; those functions include also a replacement for strlen().
9. There is a function that doesn't respect the namespace of the theme.

10.   // Only open one of the general or node setting fieldsets at a time
      $js = <<<SCRIPT
        $(document).ready(function(){
          $("fieldset.general_settings > legend > a").click(function(){
          	if(!$("fieldset.node_settings").hasClass("collapsed")) {
              Drupal.toggleFieldset($("fieldset.node_settings"));
          	}
          });
          $("fieldset.node_settings > legend > a").click(function(){
          	if (!$("fieldset.general_settings").hasClass("collapsed")) {
              Drupal.toggleFieldset($("fieldset.general_settings"));
          	}
          });
        });
    SCRIPT;
      drupal_add_js($js, 'inline');
    

    Isn't better to use drupal_add_js($js_file, 'theme')?

11.       $form['ab_container']['seo']['meta']['#description'] = 'NOTICE: You currently have the "Meta Tags (or nodewords)" module installed and enabled, so the Meta tags theme settings have been disabled to prevent conflicts.  If you wish to re-enable the Meta tags theme settings, you must first disable the "Meta Tags" module.';
    

    The string is not translatable.

The code for handling the theme settings are then taken from another theme. I am not sure we should approve a theme (or a module) that takes code from an already existing project already hosted in Drupal.org CVS.