The following returns true wherever "xri://" is defined in the identifier.

  // Strip the xri:// scheme from the identifier if present.
  if (stripos($identifier, 'xri://') !== FALSE) {
    $identifier = substr($identifier, 6);
  }

The !== FALSE needs to be replaced by === 0 as in:

  // Strip the xri:// scheme from the identifier if present.
  if (stripos($identifier, 'xri://') === 0) {
    $identifier = substr($identifier, 6);
  }

Thank you.
Alexis Wilke

CommentFileSizeAuthor
#10 openid-is-xri-D6-1.patch988 bytesc960657
#1 openid-is-xri-1.patch966 bytesc960657
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

c960657’s picture

Status: Active » Needs review
Issue tags: +Quick fix
FileSize
966 bytes

Status: Needs review » Needs work
Issue tags: -Quick fix

The last submitted patch, openid-is-xri-1.patch, failed testing.

c960657’s picture

Status: Needs work » Needs review

#1: openid-is-xri-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, openid-is-xri-1.patch, failed testing.

c960657’s picture

Status: Needs work » Needs review

#1: openid-is-xri-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Quick fix

The last submitted patch, openid-is-xri-1.patch, failed testing.

c960657’s picture

Version: 6.14 » 7.x-dev
Status: Needs work » Needs review

Ah, the test failed because the patch is against HEAD, but the version field was set to 6.14.

c960657’s picture

#1: openid-is-xri-1.patch queued for re-testing.

Dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

c960657’s picture

Version: 7.x-dev » 6.x-dev
Status: Fixed » Needs review
FileSize
988 bytes

Backport for D6.

Status: Needs review » Needs work
Issue tags: -Quick fix

The last submitted patch, openid-is-xri-D6-1.patch, failed testing.

c960657’s picture

Status: Needs work » Needs review

#10: openid-is-xri-D6-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, openid-is-xri-D6-1.patch, failed testing.

c960657’s picture

Status: Needs work » Needs review

#10: openid-is-xri-D6-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Quick fix

The last submitted patch, openid-is-xri-D6-1.patch, failed testing.

c960657’s picture

Status: Needs work » Needs review
Anonymous’s picture

Issue tags: -Quick fix

#10: openid-is-xri-D6-1.patch queued for re-testing.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.