If "There are no meta tags currently defined." the number of columns is incorrect on admin/content/nodewords/global/other. The last column have the wrong color.

Comments

avpaderno’s picture

Status: Active » Postponed (maintainer needs more info)

May you attach a screenshot of the settings page?

avpaderno’s picture

Version: 6.x-1.2 » 6.x-1.x-dev
Status: Postponed (maintainer needs more info) » Fixed

I have already fixed that problem in the development snapshot; if this is still a problem in the development snapshot, then feel free to re-open this report.

hass’s picture

Status: Fixed » Needs work
StatusFileSize
new7.36 KB

Still broken in latest DEV. Screenshot attached.

avpaderno’s picture

StatusFileSize
new38.23 KB

It seems that depends from the theme used.

avpaderno’s picture

StatusFileSize
new56.14 KB

Also changing the theme from Bluemarine to Garland, the table is shown correctly.
I am not sure how the code should be fixed; to verify which theme is being used, and then changing a parameter passed to the table theme function doesn't seem the correct way to proceed.

avpaderno’s picture

Status: Needs work » Fixed

I tried increasing the value of the attribute colspan, and it seems to work.
I guess that I must count all the columns present in the table, including the ones that will be hidden.

Thanks for the report, and the help in confirming the issue.

hass’s picture

Only for understanding… is there a reason i missed that operations must have a colspan=2 ? I haven't seen any and would better roll back the change and remove the colspan from operations column.

avpaderno’s picture

I think that colspan is needed to put both the operations under the column Operations; differently, only the first link would appear under that column.

See the code used by a Drupal core function (2 operation links, and attribute colspan set to 2):

function contact_admin_categories() {
  $result = db_query('SELECT cid, category, recipients, selected FROM {contact} ORDER BY weight, category');
  $rows = array();
  while ($category = db_fetch_object($result)) {
    $rows[] = array($category->category, $category->recipients, ($category->selected ? t('Yes') : t('No')), l(t('edit'), 'admin/build/contact/edit/'. $category->cid), l(t('delete'), 'admin/build/contact/delete/'. $category->cid));
  }
  $header = array(t('Category'), t('Recipients'), t('Selected'), array('data' => t('Operations'), 'colspan' => 2));

  return theme('table', $header, $rows);
}
hass’s picture

Are we talking about the same module? Your function is named contact_admin_categories()... this is not nodewords

avpaderno’s picture

See the code used by a Drupal core function

Would make sense to report what Nodewords does, when you are suggesting that Nodewords is doing something not correct? Indeed, it would not make sense. That is the reason I reported what Drupal code does.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.