Closed (duplicate)
Project:
Domain Relationships
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Sep 2009 at 15:15 UTC
Updated:
28 Sep 2009 at 18:45 UTC
Attached is a patch that is the result of both a strict code review in Coder, a code review with code-style.pl and a bit of manual code style review.
I feel that this code is more in line with good coding practices, more readable etc - but any feedback is much appreciated!
---
This patch is the result of around two days of work to upgrade and improve the Domain Relationships module to get some new features which we at Good Old needed for a customers site. This is one of many patches for improvements that I'm separating out of my staging git-repo: http://github.com/voxpelli/drupal-domain-relationships
| Comment | File | Size | Author |
|---|---|---|---|
| domain_relationships_code_review.patch | 7.55 KB | voxpelli |
Comments
Comment #1
nonsieDuplicate of #590368: Remove SLOC field, use cached tree hierarchy array and other improvements