this is a patch for this problem which you can found still with the latest 4.6.6 version of drupal: http://drupal.org/node/27881

CommentFileSizeAuthor
node.module_37.patch919 bytesrobertgarrigos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edrex’s picture

+1

This is still broken in 4.7. It affects me strongly because most of my sites custom theme nodes. All I get is the teaser in the node preview, because $page==0 on preview pages.

robertgarrigos’s picture

This have been solved for the last version of head (4.7! nor 4.6.6): // $Id: node.module,v 1.630 2006/04/11 11:33:15 killes Exp $

4.6.6 is still having this problem. We might have to wait until 4.7 will be released as all the forces are concentrated on it. Until then use this patch.

FlemmingLeer’s picture

Version: 4.6.6 » 4.6.7

But adding the post with the change above the page blanks. Hitting F5 or equivelant reposts the node content and still results in blank page.

It happens for both blog and article nodes.

But title did show up now after all.

I manually upgraded from 4.6.6 to 4.6.7.
I got this error message:
Cannot modify header information - headers already sent by (output started at /customers/denmarkonline.dk/denmarkonline.dk/httpd.www/modules/node.module:1) i /customers/denmarkonline.dk/denmarkonline.dk/httpd.www/includes/common.inc på linje 192.

greggles’s picture

Status: Needs review » Needs work

As you can see in http://drupal.org/node/52586 it is recommended to use drupal_clone instead of clone

greggles’s picture

Status: Needs work » Reviewed & tested by the community

I take it back - drupal_clone is not available in 4.6 http://api.drupal.org/api/4.6/function/drupal_clone (gives a 404)

Looking at the common.inc in 4.6 it implements it's own clone function if running on php< 5.0 so I believe the original patch is RTC. It didn't apply for me using "-p0" and I had to find the file manually, robertgarrigos the advice in the first comment on http://drupal.org/diffandpatch is handy on that to make the files quick to apply for reviewers.

greggles’s picture

Sorry, my use of "php > 5" messed up my post. The missing part says how I tested this patch, it worked fine but uses a very long path structure that is not standard. I feel this is RTC since it's the same solution that made into 4.7.

FlemmingLeer’s picture

np, greggles

I have to add that I did not patch it. I use windows. But the hosted server is running php5, phpMyAdmin 2.5.7-pl1 and MySQL 4.0.24.

I added the patch to line 1514, which is the correct line in 4.6.7 node.module

Thanks for looking in to it.

Dries’s picture

Isn't clone() a PHP 5 only function? (I.e. not available in PHP 4.)

greggles’s picture

Dries - from the drupal-4-6 revision of common.inc http://cvs.drupal.org/viewcvs/drupal/drupal/includes/common.inc?annotate...

1845 : 	unconed 	1.424 	 * Provide a substitute clone() function for PHP4.
1846 : 	  	  	*/
1847 : 	  	  	if (version_compare(phpversion(), '5.0') < 0) {
1848 : 	  	  	eval('
1849 : 	  	  	function clone($object) {
1850 : 	  	  	return $object;
1851 : 	  	  	}
1852 : 	  	  	');

I believe that should make this patch work for all 4.6.x installations.

FlemmingLeer’s picture

no it does not.

It blanks and gives this error message:

Placering	/node/add/blog
Besked	Cannot modify header information - headers already sent by (output started at /customers/denmarkonline.dk/denmarkonline.dk/httpd.www/modules/node.module:1) i /customers/denmarkonline.dk/denmarkonline.dk/httpd.www/includes/common.inc på linje 192.

Also i disabled Htmlarea module but even after that I get this error message. (Plus updated the html area module)

I´m going back to original 4.6.7. node.module

Any ideas ?

FlemmingLeer’s picture

Can banner.module affect this ?

And is there anyway to dump all the modules I use for your information ?

greggles’s picture

-FlemmingLeer - I don't think your problems are related to this particular issue. Please open a new forum topic or issue to cover the error messages that you are seeing.

I tried this patch on a fresh installation of Drupal4.6.7 using both PHP4.4.2 and PHP5.1.2. In both cases it worked as expected and did not create any errors on the screen or in the Drupal log. I believe this is RTC.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to DRUPAL-4-6. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)
Anonymous’s picture

Strange, i still get this bug in Drupal 5.3, when the text goes over the teaser limit, it wont show... and it's not even in the database too..

I had a look at the node.module and noticed it is, in fact, using drupal_clone() but only in one of them. I tried applying it to all but still didn't work

greggles’s picture

@xushi - your problem sounds like a new issue. Please open a new bug for it and mark the version as 5.3.