Closed (fixed)
Project:
Subscriptions
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
8 Apr 2006 at 08:02 UTC
Updated:
28 Apr 2006 at 12:33 UTC
I can't guarantee that this is accurate but it seems as though subscriptions may be causing a problem with flexinode (see node 57765.
The error shown, when viewing flexinode nodes - and sometimes even index or Views pages containing flexinode nodes is:
warning: Illegal offset type in /home/www/home/modules/flexinode/flexinode.module on line 452.
Line numbers vary depending on which patched version of flexinode you are using - and what other patches you've added to it, but the general consensus is that the offending line is:
return $types[$type]['name'];
When subscriptions is disabled, the error message doesn't appear.
Any help would be gratefully received.
Comments
Comment #1
jmiccolis commentedI think I've tracked this bug down to a bad call of the node_name hook on line 462 of subscriptions.module. The subscriptions_link function tries to get the node name by passing the full node object where it should just pass the node type.
Changing line 462 from
to
Fixes the problem for me. Sorry for not providing a patch.
Comment #2
dziemecki commentedHmmm. There must be two of these. I posted the fix for this on Saturday. Branches 4.6, 4.7, and cvs updated.
Comment #3
samc commentedHi,
Hook_node_name is no longer supported in 4.7 (see Converting 4.6 modules to 4.7) and flexinode's implementation of this will eventually be removed (see issue #31880).
The right way to get node names in 4.7 is using node_get_name(), so maybe the code in line 462 should become:
At least in the 4.7 and cvs branches.
Comment #4
dziemecki commentedGood tip. I'll look into that tonight.
Comment #5
dziemecki commentedSuggested fix committed for 4.7 and cvs.
Comment #6
dziemecki commentedFix in place 1 week, no complaints. Closing.